Bug 120393 - Make descendant iterators always require ContainerNode root
Summary: Make descendant iterators always require ContainerNode root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-27 23:43 PDT by Antti Koivisto
Modified: 2013-08-28 05:30 PDT (History)
2 users (show)

See Also:


Attachments
patch (12.96 KB, patch)
2013-08-27 23:50 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-27 23:43:50 PDT
There is no reason to iterate over Node.
Comment 1 Antti Koivisto 2013-08-27 23:50:32 PDT
Created attachment 209851 [details]
patch
Comment 2 Andreas Kling 2013-08-28 05:20:02 PDT
Comment on attachment 209851 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209851&action=review

r=me

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:416
> +    Element* canvasElement = toElement(node);

HTMLCanvasElement* canvasElement = toHTMLCanvasElement(node);
Comment 3 Antti Koivisto 2013-08-28 05:30:28 PDT
https://trac.webkit.org/r154734