Bug 120304 - Document's renderer is always a RenderView.
Summary: Document's renderer is always a RenderView.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-08-26 06:09 PDT by Andreas Kling
Modified: 2013-08-27 05:31 PDT (History)
10 users (show)

See Also:

"Patch" (11.23 KB, patch)
2013-08-26 06:48 PDT, Andreas Kling
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-26 06:09:38 PDT
Compile-time enforcement: Document's renderer is always a RenderView.
Comment 1 Andreas Kling 2013-08-26 06:48:31 PDT
Created attachment 209648 [details]
Comment 2 Darin Adler 2013-08-26 10:02:55 PDT
Comment on attachment 209648 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=209648&action=review

> Source/WebCore/dom/Document.h:1195
> +    void setRenderer(RenderObject*) WTF_DELETED_FUNCTION;

I suggest leaving out the argument:

    void setRenderer() WTF_DELETED_FUNCTION;

Makes it even less likely someone can call it by accident in a compiler that doesn't support deleting functions.
Comment 3 Andreas Kling 2013-08-27 05:31:45 PDT
Committed r154676: <http://trac.webkit.org/changeset/154676>