Bug 120274 - Improve srcset's layout tests
Summary: Improve srcset's layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-25 12:46 PDT by Yoav Weiss
Modified: 2013-08-25 14:47 PDT (History)
1 user (show)

See Also:

Attachments
Patch (45.57 KB, patch)
2013-08-25 12:56 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
Patch (45.57 KB, patch)
2013-08-25 13:01 PDT, Yoav Weiss 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2013-08-25 12:46:53 PDT 
Improve srcset's layout tests
Comment 1 Yoav Weiss 2013-08-25 12:56:17 PDT 
Created attachment 209597 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-25 12:58:31 PDT 
Attachment 209597 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-1x-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-1x.html', u'LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html', u'LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js.html', u'LayoutTests/fast/hidpi/image-srcset-data-src-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-data-src.html', u'LayoutTests/fast/hidpi/image-srcset-data-srcset-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-data-srcset.html', u'LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-invalid-inputs-correct-src.html', u'LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html', u'LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html', u'LayoutTests/fast/hidpi/image-srcset-same-alternative-for-both-attributes-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-same-alternative-for-both-attributes.html', u'LayoutTests/fast/hidpi/image-srcset-simple-1x-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-simple-1x.html', u'LayoutTests/fast/hidpi/image-srcset-simple-2x-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-simple-2x.html', u'LayoutTests/fast/hidpi/image-srcset-simple.html', u'LayoutTests/fast/hidpi/image-srcset-src-selection-1x-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-src-selection-1x.html', u'LayoutTests/fast/hidpi/image-srcset-src-selection-2x-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-src-selection-2x.html', u'LayoutTests/fast/hidpi/image-srcset-src-selection.html', u'LayoutTests/fast/hidpi/image-srcset-viewport-modifiers-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-viewport-modifiers.html', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-change-dynamically-from-js-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-data-src-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-data-srcset-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-invalid-inputs-except-one-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-remove-dynamically-from-js-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-same-alternative-for-both-attributes-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-simple-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-src-selection-expected.txt', u'LayoutTests/platform/mac/fast/hidpi/image-srcset-viewport-modifiers-expected.txt']" exit_code: 1
LayoutTests/ChangeLog:6:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
LayoutTests/ChangeLog:7:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
LayoutTests/ChangeLog:8:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
LayoutTests/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 4 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yoav Weiss 2013-08-25 13:01:40 PDT 
Created attachment 209598 [details]
Patch
Comment 4 Andreas Kling 2013-08-25 14:10:46 PDT 
Comment on attachment 209598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209598&action=review

r=me

> LayoutTests/ChangeLog:7
> +        Added expected.txt files to the test directory, since there shouldn't be any platform variance in the results.

Great!
Comment 5 WebKit Commit Bot 2013-08-25 14:47:53 PDT 
Comment on attachment 209598 [details]
Patch

Clearing flags on attachment: 209598

Committed r154582: <http://trac.webkit.org/changeset/154582>
Comment 6 WebKit Commit Bot 2013-08-25 14:47:55 PDT 
All reviewed patches have been landed.  Closing bug.