Bug 120217 - RenderView::compositor() should return a reference.
Summary: RenderView::compositor() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-23 11:54 PDT by Andreas Kling
Modified: 2013-08-23 12:01 PDT (History)
16 users (show)

See Also:


Attachments
Patch (24.26 KB, patch)
2013-08-23 11:54 PDT, Andreas Kling
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-23 11:54:19 PDT
RenderView::compositor() should return a reference.
Comment 1 Andreas Kling 2013-08-23 11:54:51 PDT
Created attachment 209482 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-23 11:56:02 PDT
Attachment 209482 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/MediaQueryEvaluator.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h']" exit_code: 1
Source/WebCore/rendering/RenderView.cpp:736:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-08-23 12:01:11 PDT
Committed r154504: <http://trac.webkit.org/changeset/154504>