Bug 12004 - Webkit doesnt handle omitting M at the start of path syntax well
Summary: Webkit doesnt handle omitting M at the start of path syntax well
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-27 13:33 PST by Rob Buis
Modified: 2006-12-31 07:10 PST (History)
0 users

See Also:

Attachments
First attempt (47.50 KB, patch)
2006-12-30 12:59 PST, Rob Buis 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2006-12-27 13:33:44 PST 
A path syntax like d='L200 0 L 200 200 L 0 200 Z L asdlkfjasdfkja' causes these warnings:

CGPathAddLineToPoint: no current point.
CGPathAddLineToPoint: no current point.
CGPathAddLineToPoint: no current point.
CGPathCloseSubpath: no current point.
CGPathAddLineToPoint: no current point.
CGPathAddCurveToPoint: no current point.
CGPathAddLineToPoint: no current point.
CGPathAddLineToPoint: no current point.
CGPathAddLineToPoint: no current point.
CGPathCloseSubpath: no current point.
CGPathAddLineToPoint: no current point.
CGPathAddCurveToPoint: no current point.

Cheers,

Rob.
Comment 1 Rob Buis 2006-12-30 12:59:01 PST 
Created attachment 12127 [details]
First attempt

The code changes are ok now I think, though the testcase may need some work.
Cheers,

Rob.
Comment 2 Eric Seidel (no email) 2006-12-30 14:40:41 PST 
Comment on attachment 12127 [details]
First attempt

The patch looks great.

We could always use more tests though.
Comment 3 Rob Buis 2006-12-31 07:10:51 PST 
Landed in r18489.