Bug 120013 - Tighten up logic in HTMLTableRowsCollection
Summary: Tighten up logic in HTMLTableRowsCollection
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
Depends on:
Reported: 2013-08-19 10:07 PDT by Darin Adler
Modified: 2013-08-21 09:36 PDT (History)
3 users (show)

See Also:

Patch (5.28 KB, patch)
2013-08-19 10:13 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (11.17 KB, text/plain)
2013-08-21 09:34 PDT, Brent Fulgham
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-08-19 10:07:15 PDT
Tighten up logic in HTMLTableRowsCollection
Comment 1 Darin Adler 2013-08-19 10:13:13 PDT
Created attachment 209099 [details]
Comment 2 Andy Estes 2013-08-19 11:02:22 PDT
Comment on attachment 209099 [details]

My preference would be to only have one definition of assertRowIsInTable() and just mark row as unused in the ASSERT_DISABLED case, but r=me either way.
Comment 3 WebKit Commit Bot 2013-08-19 12:10:37 PDT
Comment on attachment 209099 [details]

Clearing flags on attachment: 209099

Committed r154288: <http://trac.webkit.org/changeset/154288>
Comment 4 WebKit Commit Bot 2013-08-19 12:10:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2013-08-21 09:34:39 PDT
Reopening to attach new patch.
Comment 6 Brent Fulgham 2013-08-21 09:34:40 PDT
Created attachment 209274 [details]
Comment 7 Brent Fulgham 2013-08-21 09:36:17 PDT
Accidentally updated this bug, when I meant to change Bug 120113.

Sorry for the noise.