Bug 119981 - Move ElementData & co to their own files.
Summary: Move ElementData & co to their own files.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-08-18 08:29 PDT by Andreas Kling
Modified: 2013-08-18 09:02 PDT (History)
7 users (show)

See Also:

whatever (40.22 KB, patch)
2013-08-18 08:31 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-18 08:29:27 PDT
Antti keeps complaining bout Element files being cluttered.
Comment 1 Andreas Kling 2013-08-18 08:31:08 PDT
Created attachment 209034 [details]
Comment 2 WebKit Commit Bot 2013-08-18 08:34:28 PDT
Attachment 209034 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/ElementData.cpp', u'Source/WebCore/dom/ElementData.h']" exit_code: 1
Source/WebCore/dom/ElementData.cpp:248:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Source/WebCore/dom/ElementData.h:229:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 2 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-08-18 09:01:44 PDT
Committed <https://trac.webkit.org/r154249> yo.