[Soup] The testing NetworkStorageSession should have a proper SoupSession
Created attachment 208901 [details] Patch
Comment on attachment 208901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208901&action=review Does this cause any new tests to pass or does it fix some tests that are failing? > Source/WebCore/ChangeLog:3 > + <https://webkit.org/b/119887> [Soup] The testing NetworkStorageSession should have a proper SoupSession The description field is a little funky. > Source/WebCore/ChangeLog:11 > + NetworkStorageSession, which ends up being null if the testing-specific NetworkStorageSession is sued. s/sued/used
(In reply to comment #2) > > Source/WebCore/ChangeLog:3 > > + <https://webkit.org/b/119887> [Soup] The testing NetworkStorageSession should have a proper SoupSession > > The description field is a little funky. Actually it is not, the format changed recently
(In reply to comment #2) > (From update of attachment 208901 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208901&action=review > > Does this cause any new tests to pass or does it fix some tests that are failing? > There's a bit of a fallout: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20WK2%20(Tests)/r154155%20(7763)/results.html Basically, the ResourceHandleInternal's SoupSession is now null, causing crashes: STDERR: g_object_get_data: assertion `G_IS_OBJECT (object)' failed STDERR: g_object_set_data: assertion `G_IS_OBJECT (object)' failed STDERR: soup_session_request_uri: assertion `SOUP_IS_SESSION (session)' failed STDERR: g_object_set_data_full: assertion `G_IS_OBJECT (object)' failed > > Source/WebCore/ChangeLog:3 > > + <https://webkit.org/b/119887> [Soup] The testing NetworkStorageSession should have a proper SoupSession > > The description field is a little funky. > The formatting or the bug title? Formatting was changed just recently, looks nicer IMO.
Committed r154197: <http://trac.webkit.org/changeset/154197>