Bug 119660 - Make some things that return never-null pointers return references instead.
Summary: Make some things that return never-null pointers return references instead.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-11 06:51 PDT by Andreas Kling
Modified: 2013-08-11 13:25 PDT (History)
7 users (show)

See Also:


Attachments
Patch (139.52 KB, patch)
2013-08-11 06:57 PDT, Andreas Kling
koivisto: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch for landing perhaps. (145.32 KB, patch)
2013-08-11 07:22 PDT, Andreas Kling
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch for totally landing (143.80 KB, patch)
2013-08-11 08:32 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch for actually landing (145.29 KB, patch)
2013-08-11 08:33 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-11 06:51:10 PDT
Things like ensureFoo() that are guaranteed to always return an object should just return references.
Comment 1 Andreas Kling 2013-08-11 06:57:10 PDT
Created attachment 208492 [details]
Patch
Comment 2 Early Warning System Bot 2013-08-11 07:05:26 PDT
Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1414942
Comment 3 EFL EWS Bot 2013-08-11 07:06:17 PDT
Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1411860
Comment 4 Early Warning System Bot 2013-08-11 07:07:35 PDT
Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1441269
Comment 5 EFL EWS Bot 2013-08-11 07:19:48 PDT
Comment on attachment 208492 [details]
Patch

Attachment 208492 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1401792
Comment 6 Andreas Kling 2013-08-11 07:22:27 PDT
Created attachment 208493 [details]
Patch for landing perhaps.
Comment 7 Early Warning System Bot 2013-08-11 07:44:18 PDT
Comment on attachment 208493 [details]
Patch for landing perhaps.

Attachment 208493 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1414948
Comment 8 Early Warning System Bot 2013-08-11 07:45:43 PDT
Comment on attachment 208493 [details]
Patch for landing perhaps.

Attachment 208493 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1445051
Comment 9 Andreas Kling 2013-08-11 08:32:24 PDT
Created attachment 208494 [details]
Patch for totally landing
Comment 10 Andreas Kling 2013-08-11 08:33:01 PDT
Created attachment 208495 [details]
Patch for actually landing
Comment 11 Andreas Kling 2013-08-11 13:25:31 PDT
Comment on attachment 208495 [details]
Patch for actually landing

Clearing flags on attachment: 208495

Committed r153926: <http://trac.webkit.org/changeset/153926>
Comment 12 Andreas Kling 2013-08-11 13:25:38 PDT
All reviewed patches have been landed.  Closing bug.