Bug 119596 - StyleRule*::properties() should return const references.
Summary: StyleRule*::properties() should return const references.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-08 14:33 PDT by Andreas Kling
Modified: 2013-08-09 03:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (26.50 KB, patch)
2013-08-08 14:39 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (44.28 KB, patch)
2013-08-09 02:20 PDT, Andreas Kling 		koivisto: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-08 14:33:38 PDT 
Rules should always have properties inside them, so we should return const references instead of pointers.
This will expose pointless null checks.
Comment 1 Andreas Kling 2013-08-08 14:39:07 PDT 
Created attachment 208371 [details]
Patch
Comment 2 Early Warning System Bot 2013-08-08 14:44:58 PDT 
Comment on attachment 208371 [details]
Patch

Attachment 208371 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1420423
Comment 3 Early Warning System Bot 2013-08-08 14:46:27 PDT 
Comment on attachment 208371 [details]
Patch

Attachment 208371 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1432289
Comment 4 EFL EWS Bot 2013-08-08 14:47:31 PDT 
Comment on attachment 208371 [details]
Patch

Attachment 208371 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1434273
Comment 5 EFL EWS Bot 2013-08-08 14:51:34 PDT 
Comment on attachment 208371 [details]
Patch

Attachment 208371 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1367534
Comment 6 Andreas Kling 2013-08-08 16:00:51 PDT 
Comment on attachment 208371 [details]
Patch

Keyframe rules appear to be the exception here. Needs some tlc.
Comment 7 Andreas Kling 2013-08-09 02:20:36 PDT 
Created attachment 208407 [details]
Patch
Comment 8 Antti Koivisto 2013-08-09 02:23:04 PDT 
Comment on attachment 208407 [details]
Patch

r=me
Comment 9 EFL EWS Bot 2013-08-09 02:29:15 PDT 
Comment on attachment 208407 [details]
Patch

Attachment 208407 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1401124
Comment 10 EFL EWS Bot 2013-08-09 02:30:07 PDT 
Comment on attachment 208407 [details]
Patch

Attachment 208407 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1414278
Comment 11 Andreas Kling 2013-08-09 03:00:22 PDT 
Committed r153880: <http://trac.webkit.org/changeset/153880>