WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
119596
StyleRule*::properties() should return const references.
https://bugs.webkit.org/show_bug.cgi?id=119596
Summary
StyleRule*::properties() should return const references.
Andreas Kling
Reported
2013-08-08 14:33:38 PDT
Rules should always have properties inside them, so we should return const references instead of pointers. This will expose pointless null checks.
Attachments
Patch
(26.50 KB, patch)
2013-08-08 14:39 PDT
,
Andreas Kling
webkit-ews
: commit-queue-
Details
Formatted Diff
Diff
Patch
(44.28 KB, patch)
2013-08-09 02:20 PDT
,
Andreas Kling
koivisto
: review+
eflews.bot
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-08-08 14:39:07 PDT
Created
attachment 208371
[details]
Patch
Early Warning System Bot
Comment 2
2013-08-08 14:44:58 PDT
Comment on
attachment 208371
[details]
Patch
Attachment 208371
[details]
did not pass qt-ews (qt): Output:
http://webkit-queues.appspot.com/results/1420423
Early Warning System Bot
Comment 3
2013-08-08 14:46:27 PDT
Comment on
attachment 208371
[details]
Patch
Attachment 208371
[details]
did not pass qt-wk2-ews (qt-wk2): Output:
http://webkit-queues.appspot.com/results/1432289
EFL EWS Bot
Comment 4
2013-08-08 14:47:31 PDT
Comment on
attachment 208371
[details]
Patch
Attachment 208371
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/1434273
EFL EWS Bot
Comment 5
2013-08-08 14:51:34 PDT
Comment on
attachment 208371
[details]
Patch
Attachment 208371
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/1367534
Andreas Kling
Comment 6
2013-08-08 16:00:51 PDT
Comment on
attachment 208371
[details]
Patch Keyframe rules appear to be the exception here. Needs some tlc.
Andreas Kling
Comment 7
2013-08-09 02:20:36 PDT
Created
attachment 208407
[details]
Patch
Antti Koivisto
Comment 8
2013-08-09 02:23:04 PDT
Comment on
attachment 208407
[details]
Patch r=me
EFL EWS Bot
Comment 9
2013-08-09 02:29:15 PDT
Comment on
attachment 208407
[details]
Patch
Attachment 208407
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/1401124
EFL EWS Bot
Comment 10
2013-08-09 02:30:07 PDT
Comment on
attachment 208407
[details]
Patch
Attachment 208407
[details]
did not pass efl-wk2-ews (efl-wk2): Output:
http://webkit-queues.appspot.com/results/1414278
Andreas Kling
Comment 11
2013-08-09 03:00:22 PDT
Committed
r153880
: <
http://trac.webkit.org/changeset/153880
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug