Bug 119555 - 32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
Summary: 32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-07 11:25 PDT by Mark Hahnenberg
Modified: 2013-08-07 11:35 PDT (History)
0 users

See Also:

Attachments
Patch (1.76 KB, patch)
2013-08-07 11:27 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-08-07 11:25:26 PDT 
It uses a speculationCheck where it should be using a DFG_TYPE_CHECK like the 64-bit backend does.
Comment 1 Mark Hahnenberg 2013-08-07 11:25:55 PDT 
<rdar://problem/14666354>
Comment 2 Mark Hahnenberg 2013-08-07 11:27:07 PDT 
Created attachment 208287 [details]
Patch
Comment 3 Geoffrey Garen 2013-08-07 11:29:34 PDT 
Comment on attachment 208287 [details]
Patch

r=me
Comment 4 Mark Hahnenberg 2013-08-07 11:35:21 PDT 
Committed r153793: <http://trac.webkit.org/changeset/153793>