Bug 119407 - Minor cleanup for srcset tests
Summary: Minor cleanup for srcset tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on: 110252
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-01 13:32 PDT by Dean Jackson
Modified: 2013-08-01 17:03 PDT (History)
1 user (show)

See Also:


Attachments
Patch (126.34 KB, patch)
2013-08-01 13:36 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-08-01 13:32:25 PDT
Once img srcset lands (110252), cleanup some of the tests. In particular:

- collect duplicated code into a helper function
- make sure dynamic removal/adding tests run outside DRT
- fix typos
Comment 1 Radar WebKit Bug Importer 2013-08-01 13:33:05 PDT
<rdar://problem/14623918>
Comment 2 Dean Jackson 2013-08-01 13:36:42 PDT
Created attachment 207947 [details]
Patch
Comment 3 Dean Jackson 2013-08-01 17:03:51 PDT
Committed r153625: <http://trac.webkit.org/changeset/153625>