Bug 119262 - Cleanup CMake files in WebCore
Summary: Cleanup CMake files in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 121764
  Show dependency treegraph
 
Reported: 2013-07-30 09:01 PDT by Patrick R. Gansterer
Modified: 2013-09-23 01:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (28.98 KB, patch)
2013-07-30 09:05 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (74.92 KB, patch)
2013-09-22 04:20 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (74.69 KB, patch)
2013-09-22 04:39 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (74.40 KB, patch)
2013-09-22 05:26 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-07-30 09:01:34 PDT
Cleanup CMake files in WebCore
Comment 1 Patrick R. Gansterer 2013-07-30 09:05:15 PDT
Created attachment 207741 [details]
Patch
Comment 2 Ryosuke Niwa 2013-08-01 20:43:10 PDT
It seems like this patch doesn't apply cleanly?
Comment 3 Patrick R. Gansterer 2013-09-22 04:20:25 PDT
Created attachment 212297 [details]
Patch
Comment 4 EFL EWS Bot 2013-09-22 04:23:58 PDT
Comment on attachment 212297 [details]
Patch

Attachment 212297 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2022150
Comment 5 EFL EWS Bot 2013-09-22 04:24:00 PDT
Comment on attachment 212297 [details]
Patch

Attachment 212297 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1978036
Comment 6 Patrick R. Gansterer 2013-09-22 04:39:58 PDT
Created attachment 212299 [details]
Patch
Comment 7 EFL EWS Bot 2013-09-22 04:53:16 PDT
Comment on attachment 212299 [details]
Patch

Attachment 212299 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1914548
Comment 8 EFL EWS Bot 2013-09-22 05:25:59 PDT
Comment on attachment 212299 [details]
Patch

Attachment 212299 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1908225
Comment 9 Patrick R. Gansterer 2013-09-22 05:26:40 PDT
Created attachment 212301 [details]
Patch
Comment 10 Gyuyoung Kim 2013-09-22 18:44:10 PDT
Comment on attachment 212301 [details]
Patch

LGTM. r=me.
Comment 11 WebKit Commit Bot 2013-09-23 01:24:53 PDT
Comment on attachment 212301 [details]
Patch

Clearing flags on attachment: 212301

Committed r156267: <http://trac.webkit.org/changeset/156267>
Comment 12 WebKit Commit Bot 2013-09-23 01:24:56 PDT
All reviewed patches have been landed.  Closing bug.