Changed attribute name from check_xvfb to check_driver
Created attachment 207702 [details] Patch
Attachment 207702 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/port/efl.py']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 207704 [details] Patch
Comment on attachment 207704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207704&action=review > Tools/Scripts/webkitpy/port/efl.py:136 > + return super(EflPort, self).check_sys_deps(needs_http) and XvfbDriver.check_driver(self) Please use self._driver_class().check_driver(self) for consistency with gtk.
Created attachment 207708 [details] Patch
Comment on attachment 207708 [details] Patch Ok, r=me.
Comment on attachment 207708 [details] Patch Clearing flags on attachment: 207708 Committed r153470: <http://trac.webkit.org/changeset/153470>
All reviewed patches have been landed. Closing bug.
I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change.
(In reply to comment #9) > I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change. Yes, it was a bit surprising, especially without warning. But no worries, we understand such things happen inadvertently.