RESOLVED FIXED119240
[EFL] REGRESSION after r153439: layout tests do not run. 
https://bugs.webkit.org/show_bug.cgi?id=119240
Summary [EFL] REGRESSION after r153439: layout tests do not run.
Krzysztof Czech
Reported 2013-07-30 02:15:14 PDT
Changed attribute name from check_xvfb to check_driver
Attachments
Patch (1.09 KB, patch)
2013-07-30 02:15 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Patch (1.11 KB, patch)
2013-07-30 02:22 PDT, Krzysztof Czech 		cdumez: review-
cdumez: commit-queue-
DetailsFormatted DiffDiff
Patch (1.12 KB, patch)
2013-07-30 03:16 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2013-07-30 02:15:57 PDT
Created attachment 207702 [details] Patch
WebKit Commit Bot
Comment 2 2013-07-30 02:18:07 PDT
Attachment 207702 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/port/efl.py']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Krzysztof Czech
Comment 3 2013-07-30 02:22:01 PDT
Created attachment 207704 [details] Patch
Chris Dumez
Comment 4 2013-07-30 03:09:23 PDT
Comment on attachment 207704 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207704&action=review > Tools/Scripts/webkitpy/port/efl.py:136 > + return super(EflPort, self).check_sys_deps(needs_http) and XvfbDriver.check_driver(self) Please use self._driver_class().check_driver(self) for consistency with gtk.
Krzysztof Czech
Comment 5 2013-07-30 03:16:52 PDT
Created attachment 207708 [details] Patch
Chris Dumez
Comment 6 2013-07-30 03:18:15 PDT
Comment on attachment 207708 [details] Patch Ok, r=me.
Chris Dumez
Comment 7 2013-07-30 06:50:38 PDT
Comment on attachment 207708 [details] Patch Clearing flags on attachment: 207708 Committed r153470: <http://trac.webkit.org/changeset/153470>
Chris Dumez
Comment 8 2013-07-30 06:50:59 PDT
All reviewed patches have been landed. Closing bug.
Zan Dobersek
Comment 9 2013-07-31 04:30:07 PDT
I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change.
Chris Dumez
Comment 10 2013-07-31 04:35:02 PDT
(In reply to comment #9) > I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change. Yes, it was a bit surprising, especially without warning. But no worries, we understand such things happen inadvertently.
Note You need to log in before you can comment on or make changes to this bug.