Bug 119240 - [EFL] REGRESSION after r153439: layout tests do not run.
Summary: [EFL] REGRESSION after r153439: layout tests do not run.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 02:15 PDT by Krzysztof Czech
Modified: 2013-07-31 04:35 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.09 KB, patch)
2013-07-30 02:15 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff
Patch (1.11 KB, patch)
2013-07-30 02:22 PDT, Krzysztof Czech
cdumez: review-
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch (1.12 KB, patch)
2013-07-30 03:16 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-07-30 02:15:14 PDT
Changed attribute name from check_xvfb to check_driver
Comment 1 Krzysztof Czech 2013-07-30 02:15:57 PDT
Created attachment 207702 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-30 02:18:07 PDT
Attachment 207702 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/port/efl.py']" exit_code: 1
Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Krzysztof Czech 2013-07-30 02:22:01 PDT
Created attachment 207704 [details]
Patch
Comment 4 Chris Dumez 2013-07-30 03:09:23 PDT
Comment on attachment 207704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207704&action=review

> Tools/Scripts/webkitpy/port/efl.py:136
> +        return super(EflPort, self).check_sys_deps(needs_http) and XvfbDriver.check_driver(self)

Please use self._driver_class().check_driver(self) for consistency with gtk.
Comment 5 Krzysztof Czech 2013-07-30 03:16:52 PDT
Created attachment 207708 [details]
Patch
Comment 6 Chris Dumez 2013-07-30 03:18:15 PDT
Comment on attachment 207708 [details]
Patch

Ok, r=me.
Comment 7 Chris Dumez 2013-07-30 06:50:38 PDT
Comment on attachment 207708 [details]
Patch

Clearing flags on attachment: 207708

Committed r153470: <http://trac.webkit.org/changeset/153470>
Comment 8 Chris Dumez 2013-07-30 06:50:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Zan Dobersek 2013-07-31 04:30:07 PDT
I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change.
Comment 10 Chris Dumez 2013-07-31 04:35:02 PDT
(In reply to comment #9)
> I apologize for the breakage. Immensely stupid on my side not to think of other ports that were affected by the XvfbDriver change.

Yes, it was a bit surprising, especially without warning. But no worries, we understand such things happen inadvertently.