[CSS Shapes] Stop using internals in shape-outside tests
Created attachment 207678 [details] Patch Remove use of internals, since it isn't needed anymore, and makes csswg tests cleaner
Comment on attachment 207678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207678&action=review Looks a lot better. Please update SUBPIXELS_FOR_PIXEL back to SUBPIXELS_PER_PIXEL before committing. > LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js:21 > + return isEnabled() ? Math.floor(f * SUBPIXELS_FOR_PIXEL) / SUBPIXELS_FOR_PIXEL : Math.floor(f); // as in LayoutUnit(f).toFloat() Why do you need this change? > LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js:24 > + return isEnabled() ? Math.ceil(f * SUBPIXELS_FOR_PIXEL) / SUBPIXELS_FOR_PIXEL : Math.ceil(f); // see ceiledLayoutUnit(), LayoutUnit.h ditto
Created attachment 207855 [details] Patch Update for review comments
Comment on attachment 207855 [details] Patch Rejecting attachment 207855 [details] from commit-queue. bjonesbe@adobe.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 207855 [details] Patch This time with feeling. (It seems like the bot has been restarted in the meantime. :-)
Comment on attachment 207855 [details] Patch Clearing flags on attachment: 207855 Committed r153528: <http://trac.webkit.org/changeset/153528>
All reviewed patches have been landed. Closing bug.