Bug 119229 - [CSS Shapes] Stop using internals in shape-outside tests
Summary: [CSS Shapes] Stop using internals in shape-outside tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
Depends on:
Blocks: 117898
  Show dependency treegraph
Reported: 2013-07-29 16:11 PDT by Bem Jones-Bey
Modified: 2013-07-31 11:17 PDT (History)
1 user (show)

See Also:

Patch (50.58 KB, patch)
2013-07-29 16:15 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff
Patch (49.18 KB, patch)
2013-07-31 09:56 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-07-29 16:11:36 PDT
[CSS Shapes] Stop using internals in shape-outside tests
Comment 1 Bem Jones-Bey 2013-07-29 16:15:43 PDT
Created attachment 207678 [details]

Remove use of internals, since it isn't needed anymore, and makes csswg tests cleaner
Comment 2 Alexandru Chiculita 2013-07-31 09:53:25 PDT
Comment on attachment 207678 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=207678&action=review

Looks a lot better. Please update SUBPIXELS_FOR_PIXEL back to SUBPIXELS_PER_PIXEL before committing.

> LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js:21
> +            return isEnabled() ? Math.floor(f * SUBPIXELS_FOR_PIXEL) / SUBPIXELS_FOR_PIXEL : Math.floor(f); // as in LayoutUnit(f).toFloat()

Why do you need this change?

> LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js:24
> +            return isEnabled() ? Math.ceil(f * SUBPIXELS_FOR_PIXEL) / SUBPIXELS_FOR_PIXEL : Math.ceil(f); // see ceiledLayoutUnit(), LayoutUnit.h

Comment 3 Bem Jones-Bey 2013-07-31 09:56:20 PDT
Created attachment 207855 [details]

Update for review comments
Comment 4 WebKit Commit Bot 2013-07-31 09:57:16 PDT
Comment on attachment 207855 [details]

Rejecting attachment 207855 [details] from commit-queue.

bjonesbe@adobe.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 Bem Jones-Bey 2013-07-31 11:14:12 PDT
Comment on attachment 207855 [details]

This time with feeling. (It seems like the bot has been restarted in the meantime. :-)
Comment 6 WebKit Commit Bot 2013-07-31 11:17:26 PDT
Comment on attachment 207855 [details]

Clearing flags on attachment: 207855

Committed r153528: <http://trac.webkit.org/changeset/153528>
Comment 7 WebKit Commit Bot 2013-07-31 11:17:27 PDT
All reviewed patches have been landed.  Closing bug.