Bug 118988 - Use Checked<uint32_t, RecordOverflow> instead of CheckedInt in GraphicsContext3D
Summary: Use Checked<uint32_t, RecordOverflow> instead of CheckedInt in GraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-22 14:05 PDT by Zan Dobersek
Modified: 2013-09-05 10:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.85 KB, patch)
2013-07-22 14:12 PDT, Zan Dobersek 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-07-22 14:05:18 PDT 
Use Checked<uint32_t, RecordOverflow> instead of CheckedInt in GraphicsContext3D
Comment 1 Zan Dobersek 2013-07-22 14:12:43 PDT 
Created attachment 207277 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-22 14:13:52 PDT 
Attachment 207277 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/GraphicsContext3D.cpp']" exit_code: 1
Source/WebCore/platform/graphics/GraphicsContext3D.cpp:210:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2013-09-05 10:16:51 PDT 
Landed in r153062.
http://trac.webkit.org/changeset/153062