Created attachment 207265 [details] test case Invoking Dictionary on text in attached test case results in a wildly mispositioned highlight. To reproduce, invoke Dictionary with Safari context menu, or with Cmd+Ctrl+D shortcut.
<rdar://problem/25660622>
@ap - Does 'Dictionary' got replaced by some other tool? CMD+Ctrl+D is not doing anything for me even when I have selection on text? Is it 'Look Up' feature or do I have to enable something from Safari settings?
(In reply to Ahmad Saleem from comment #2) > @ap - Does 'Dictionary' got replaced by some other tool? CMD+Ctrl+D is not > doing anything for me even when I have selection on text? > > Is it 'Look Up' feature or do I have to enable something from Safari > settings? I think this now works through Control-(mouse)click, then "Lookup". This seems to work fine for the attachment.
(In reply to Rob Buis from comment #3) > (In reply to Ahmad Saleem from comment #2) > > @ap - Does 'Dictionary' got replaced by some other tool? CMD+Ctrl+D is not > > doing anything for me even when I have selection on text? > > > > Is it 'Look Up' feature or do I have to enable something from Safari > > settings? > > I think this now works through Control-(mouse)click, then "Lookup". This > seems to work fine for the attachment. Having said that, the highlight seems to make the background and text both yellow, unlike for HTML, where the text is still readable.
So looks like firstRectForCharacterRange is probably fixed, but there is a new issue with text not showing up. Could be a recent-ish regression.