Bug 118935 - fourthTier: String GetByVal out-of-bounds handling is so wrong
Summary: fourthTier: String GetByVal out-of-bounds handling is so wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 118910
  Show dependency treegraph
 
Reported: 2013-07-19 20:52 PDT by Filip Pizlo
Modified: 2013-07-20 10:57 PDT (History)
7 users (show)

See Also:


Attachments
work in progress (9.09 KB, patch)
2013-07-19 20:53 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (28.30 KB, patch)
2013-07-19 21:43 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (31.01 KB, patch)
2013-07-19 22:21 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-07-19 20:52:35 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2013-07-19 20:53:34 PDT
Created attachment 207178 [details]
work in progress

This adds test, and some test support that I needed, when building them.
Comment 2 Filip Pizlo 2013-07-19 21:43:48 PDT
Created attachment 207180 [details]
the patch

I'll have -expected files shortly.
Comment 3 Filip Pizlo 2013-07-19 22:21:45 PDT
Created attachment 207185 [details]
the patch

and now, with tests!
Comment 4 Geoffrey Garen 2013-07-20 09:29:49 PDT
Comment on attachment 207185 [details]
the patch

JavaScript is the best.
Comment 5 Filip Pizlo 2013-07-20 10:57:56 PDT
Landed in http://trac.webkit.org/changeset/152944