Bug 118852 - CodeBlock::m_argumentValueProfiles wastes a lot of memory.
Summary: CodeBlock::m_argumentValueProfiles wastes a lot of memory.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: InRadar, Performance
Depends on:
Reported: 2013-07-18 09:01 PDT by Andreas Kling
Modified: 2013-07-18 09:51 PDT (History)
5 users (show)

See Also:

Patch (2.92 KB, patch)
2013-07-18 09:07 PDT, Andreas Kling
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-07-18 09:01:36 PDT
"resize() once, append() never" is not a great pattern.
Comment 1 Radar WebKit Bug Importer 2013-07-18 09:03:26 PDT
Comment 2 Andreas Kling 2013-07-18 09:07:16 PDT
Created attachment 206994 [details]
Comment 3 WebKit Commit Bot 2013-07-18 09:08:40 PDT
Attachment 206994 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h']" exit_code: 1
Source/WTF/wtf/Vector.h:611:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2013-07-18 09:51:42 PDT
Committed r152848: <http://trac.webkit.org/changeset/152848>