Bug 118802 - Fix TimeRanges::intersectWith
Summary: Fix TimeRanges::intersectWith
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks: 125898
  Show dependency tree / graph
 
Reported: 2013-07-17 10:22 PDT by Eric Carlson
Modified: 2022-10-14 07:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.71 KB, patch)
2013-07-17 11:35 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (17.15 KB, patch)
2013-12-17 16:36 PST, Jer Noble 		jer.noble: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (17.58 KB, patch)
2013-12-17 16:54 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-07-17 10:22:36 PDT 
Consider merging blink bug 19054009 - https://src.chromium.org/viewvc/blink?view=rev&revision=154041
Comment 1 Jer Noble 2013-07-17 10:46:50 PDT 
That blink patch has a number of unrelated changes.  Merging in a subset of that patch.
Comment 2 Jer Noble 2013-07-17 11:35:53 PDT 
Created attachment 206903 [details]
Patch
Comment 3 WebKit Commit Bot 2013-07-17 13:14:56 PDT 
Comment on attachment 206903 [details]
Patch

Rejecting attachment 206903 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 206903, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1098282
Comment 4 Jer Noble 2013-07-17 13:23:58 PDT 
Forgot the "Reviewed by:" line in WebCore/ChangeLog; fixing and landing manually.
Comment 5 Jer Noble 2013-12-17 16:36:26 PST 
Created attachment 219468 [details]
Patch for landing
Comment 6 Jer Noble 2013-12-17 16:54:17 PST 
Created attachment 219476 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-12-17 21:33:47 PST 
Comment on attachment 219476 [details]
Patch for landing

Clearing flags on attachment: 219476

Committed r160749: <http://trac.webkit.org/changeset/160749>
Comment 8 Ahmad Saleem 2022-10-14 07:57:26 PDT 
Landed - https://github.com/WebKit/WebKit/commit/629c30d5301c181483003ae31a5dd51afa41911c

and didn't backed out.

Marking this as "RESOLVED FIXED".
Comment 9 Radar WebKit Bug Importer 2022-10-14 07:58:18 PDT 
<rdar://problem/101172673>