Bug 118438 - Fix the performance regressions introduced by r152418
Summary: Fix the performance regressions introduced by r152418
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 118415
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-05 17:30 PDT by Benjamin Poulain
Modified: 2013-07-06 23:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2013-07-05 17:36 PDT, Benjamin Poulain
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-07-05 17:30:19 PDT
Fix the performance regressions introduced by r152418
Comment 1 Benjamin Poulain 2013-07-05 17:36:09 PDT
Created attachment 206178 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2013-07-05 20:45:15 PDT
Comment on attachment 206178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206178&action=review

Looks great, thanks for fixing it.

> Source/WTF/wtf/text/StringImpl.h:1093
> +ALWAYS_INLINE bool equal(const UChar* a, const LChar* b, unsigned length)

maybe it's worth saving couple of lines of code putting the function body to the same line?
Comment 3 Benjamin Poulain 2013-07-05 20:48:17 PDT
> maybe it's worth saving couple of lines of code putting the function body to the same line?

Sure, I'll change that before landing.
Comment 4 Benjamin Poulain 2013-07-06 23:47:34 PDT
Committed r152438: <http://trac.webkit.org/changeset/152438>