Bug 118204 - std::min needs template parameters
Summary: std::min needs template parameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 14:49 PDT by Alex Christensen
Modified: 2013-06-28 15:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2013-06-28 15:09 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-28 14:49:41 PDT 
https://bugs.webkit.org/show_bug.cgi?id=94124 committed in r135763 fixed a compile error with template parameters std::min, but there are two more places where this needs to be done.  Visual Studio can't decide whether to use the 32-bit or 64-bit integer comparison, so I'm going to tell it to cast both to the desired return type first.
Comment 1 Alex Christensen 2013-06-28 15:09:52 PDT 
Created attachment 205747 [details]
Patch
Comment 2 Geoffrey Garen 2013-06-28 15:13:36 PDT 
Comment on attachment 205747 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-06-28 15:48:50 PDT 
Comment on attachment 205747 [details]
Patch

Clearing flags on attachment: 205747

Committed r152193: <http://trac.webkit.org/changeset/152193>
Comment 4 WebKit Commit Bot 2013-06-28 15:48:52 PDT 
All reviewed patches have been landed.  Closing bug.