Bug 117993 - SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1
Summary: SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-25 08:28 PDT by Cosmin Truta
Modified: 2013-08-08 09:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2013-06-25 08:30 PDT, Cosmin Truta
fpizlo: review-
fpizlo: commit-queue-
Details | Formatted Diff | Diff
Patch (1.85 MB, patch)
2013-07-03 10:46 PDT, Cosmin Truta
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cosmin Truta 2013-06-25 08:28:02 PDT
Changeset 149548 was committed without updating the SunSpider 1.0 website.
A patch will follow.
Comment 1 Cosmin Truta 2013-06-25 08:30:48 PDT
Created attachment 205405 [details]
Patch
Comment 2 George Staikos 2013-07-03 05:54:23 PDT
Comment on attachment 205405 [details]
Patch

This makes a lot more sense to me.
Comment 3 Filip Pizlo 2013-07-03 07:28:08 PDT
I think we owe it to the community to do proper versioning here. Please prepare a SunSpider 1.0.1, and make sure that SunSpider 1.0 still has the bug. In fact, I'm shocked that you guys landed the fix in the SunSpider 1.0 directory in the first place - I would revert this. The whole point of having versions is that running a particular version always gives the same results.
Comment 4 Cosmin Truta 2013-07-03 08:44:18 PDT
Changing the bug title to reflect the upcoming work. A patch will follow.
Comment 5 Cosmin Truta 2013-07-03 10:46:34 PDT
Created attachment 206011 [details]
Patch

So, Filip, we reverted the SunSpider 1.0 change and prepared a new version 1.0.1, as you suggested.

I will appreciate your input. Is a public announcement, or other things, needed? We are affected by this issue, so we need to move on and get it fixed.
Comment 6 George Staikos 2013-07-04 16:33:12 PDT
(In reply to comment #3)
> I think we owe it to the community to do proper versioning here. Please prepare a SunSpider 1.0.1, and make sure that SunSpider 1.0 still has the bug. In fact, I'm shocked that you guys landed the fix in the SunSpider 1.0 directory in the first place - I would revert this. The whole point of having versions is that running a particular version always gives the same results.

I'll leave the new r+ to Filip since it's his request, but really SunSpider 1.0 is broken.  This isn't a new version, it's just a fix of the old one.
Comment 7 Srikumar B 2013-07-10 12:26:00 PDT
Filip, Can you review new patch? Its just a kind reminder.
Comment 8 George Staikos 2013-08-07 09:48:53 PDT
Comment on attachment 206011 [details]
Patch

This seems very reasonable to me.
Comment 9 Cosmin Truta 2013-08-08 09:29:56 PDT
Comment on attachment 206011 [details]
Patch

Thank you for the review. Committing.
By the way, I noticed this change fixes the 3d-morph execution on Windows Phone also.
Comment 10 WebKit Commit Bot 2013-08-08 09:54:13 PDT
Comment on attachment 206011 [details]
Patch

Clearing flags on attachment: 206011

Committed r153824: <http://trac.webkit.org/changeset/153824>
Comment 11 WebKit Commit Bot 2013-08-08 09:54:16 PDT
All reviewed patches have been landed.  Closing bug.