Bug 117982 - [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
Summary: [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-25 05:39 PDT by Carlos Garcia Campos
Modified: 2013-06-27 00:00 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.12 KB, patch)
2013-06-25 05:47 PDT, Carlos Garcia Campos
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-06-25 05:39:33 PDT
It's currently implemented, but the permissive flag is ignored.
Comment 1 Carlos Garcia Campos 2013-06-25 05:47:10 PDT
Created attachment 205386 [details]
Patch

Fixes test fast/loader/onload-policy-ignore-for-frame.html
Comment 2 Rob Buis 2013-06-26 12:43:32 PDT
Comment on attachment 205386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205386&action=review

LGTM.

> Source/WebKit/blackberry/ChangeLog:8
> +        Take custom cpolicy into account when deciding the policy for

I assume you mean 'policy' here instead of 'cpolicy'.
Comment 3 Carlos Garcia Campos 2013-06-26 23:57:22 PDT
(In reply to comment #2)
> (From update of attachment 205386 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205386&action=review
> 
> LGTM.
> 
> > Source/WebKit/blackberry/ChangeLog:8
> > +        Take custom cpolicy into account when deciding the policy for
> 
> I assume you mean 'policy' here instead of 'cpolicy'.

Oops, yes, it's a typo, will fix it before landing.
Comment 4 Carlos Garcia Campos 2013-06-27 00:00:47 PDT
Committed r152081: <http://trac.webkit.org/changeset/152081>