Bug 117955 - OpenGL needs PLATFORM(WIN)
Summary: OpenGL needs PLATFORM(WIN)
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
Depends on:
Reported: 2013-06-24 15:42 PDT by Alex Christensen
Modified: 2013-06-25 10:45 PDT (History)
5 users (show)

See Also:

Patch (7.99 KB, patch)
2013-06-24 15:48 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-24 15:42:20 PDT
I added PLATFORM(WIN) to many places where it was missing in WebGL code in https://bugs.webkit.org/show_bug.cgi?id=117805 but I missed many places in the OpenGL code.  I think I got all of them this time.
Comment 1 Alex Christensen 2013-06-24 15:48:30 PDT
Created attachment 205336 [details]
Comment 2 Brent Fulgham 2013-06-24 16:22:38 PDT
Comment on attachment 205336 [details]

Looks good. r=me.  But let's wait for EWS to finish before landing it.  Just in case...
Comment 3 Alex Christensen 2013-06-24 23:42:48 PDT
Don't cq+ this yet.  I think some of these might need to be true for apple win and false for wincairo.  Let me double check them.
Comment 4 WebKit Commit Bot 2013-06-25 10:45:36 PDT
Comment on attachment 205336 [details]

Clearing flags on attachment: 205336

Committed r151966: <http://trac.webkit.org/changeset/151966>
Comment 5 WebKit Commit Bot 2013-06-25 10:45:39 PDT
All reviewed patches have been landed.  Closing bug.