WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117955
OpenGL needs PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=117955
Summary
OpenGL needs PLATFORM(WIN)
Alex Christensen
Reported
2013-06-24 15:42:20 PDT
I added PLATFORM(WIN) to many places where it was missing in WebGL code in
https://bugs.webkit.org/show_bug.cgi?id=117805
but I missed many places in the OpenGL code. I think I got all of them this time.
Attachments
Patch
(7.99 KB, patch)
2013-06-24 15:48 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2013-06-24 15:48:30 PDT
Created
attachment 205336
[details]
Patch
Brent Fulgham
Comment 2
2013-06-24 16:22:38 PDT
Comment on
attachment 205336
[details]
Patch Looks good. r=me. But let's wait for EWS to finish before landing it. Just in case...
Alex Christensen
Comment 3
2013-06-24 23:42:48 PDT
Don't cq+ this yet. I think some of these might need to be true for apple win and false for wincairo. Let me double check them.
WebKit Commit Bot
Comment 4
2013-06-25 10:45:36 PDT
Comment on
attachment 205336
[details]
Patch Clearing flags on attachment: 205336 Committed
r151966
: <
http://trac.webkit.org/changeset/151966
>
WebKit Commit Bot
Comment 5
2013-06-25 10:45:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug