Bug 117931 - [CMAKE] Clear unused cmakedefines
Summary: [CMAKE] Clear unused cmakedefines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 05:13 PDT by Ryuan Choi
Modified: 2013-06-24 05:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.74 KB, patch)
2013-06-24 05:16 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-06-24 05:13:09 PDT 
Long time ago, below feature macros are removed, but defines are remained.

ENABLE_AS_IMAGE removed at r95234 and r95665
ENABLE_LEGACY_WEBKIT_BLOB_BUILDER removed at r130343
ENABLE_CLIENT_BASED_GEOLOCATION removed at r110595 but restored at 112654
Comment 1 Ryuan Choi 2013-06-24 05:16:44 PDT 
Created attachment 205286 [details]
Patch
Comment 2 Chris Dumez 2013-06-24 05:21:08 PDT 
Comment on attachment 205286 [details]
Patch

ok, r=me.
Comment 3 Ryuan Choi 2013-06-24 05:32:12 PDT 
Committed r151905: <http://trac.webkit.org/changeset/151905>