Bug 117479 - Remove virtual from functions that are never overridden
Summary: Remove virtual from functions that are never overridden
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks:
 
Reported: 2013-06-10 21:07 PDT by Ryosuke Niwa
Modified: 2014-02-07 11:33 PST (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-10 21:07:05 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/27ae848f12fb48ae823605c434b4a3ce96ac2c53

I checked these by writing a quick Python script; none of these functions
are found in any other header files in this directory.

I was surprised how much this cuts down on code size. I'm going to
aggressively get rid of virtual functions when they're not useful.
The main reason this helps so much is because there are so many subclasses of AccessibilityObject.

I wonder if we have LLVM tool that finds unnecessary virtual for us?
Comment 3 chris fleizach 2013-06-10 23:43:14 PDT 
Yea we should definitely do this, but I straight merge probably won't anymore now that they're pulling AX code out. We'll need to go through by hand and do this
Comment 5 Radar WebKit Bug Importer 2014-02-07 11:33:29 PST 
<rdar://problem/16014095>