Bug 117350 - Get rid of outdated raises() from Web IDL
Summary: Get rid of outdated raises() from Web IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 117400
  Show dependency tree / graph
 
Reported: 2013-06-07 08:37 PDT by Chris Dumez
Modified: 2013-06-10 03:10 PDT (History)
14 users (show)

See Also:

Attachments
Patch (247.90 KB, patch)
2013-06-07 10:07 PDT, Chris Dumez 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (247.90 KB, patch)
2013-06-07 10:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-07 08:37:18 PDT 
Web IDL no longer specifies exceptions for operations / methods and this is now only explained in prose. WebKit still needs to know that an exception can be raised though (to pass ExceptionCode argument) so we should add a WebKit-specific IDL extended attribute:
RaisesException (naming is consistent with Blink).
Comment 1 Chris Dumez 2013-06-07 10:07:11 PDT 
Created attachment 204050 [details]
Patch
Comment 2 Early Warning System Bot 2013-06-07 10:14:11 PDT 
Comment on attachment 204050 [details]
Patch

Attachment 204050 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/743518
Comment 3 kov's GTK+ EWS bot 2013-06-07 10:17:11 PDT 
Comment on attachment 204050 [details]
Patch

Attachment 204050 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/661574
Comment 4 EFL EWS Bot 2013-06-07 10:19:32 PDT 
Comment on attachment 204050 [details]
Patch

Attachment 204050 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/755259
Comment 5 Chris Dumez 2013-06-07 10:19:51 PDT 
Created attachment 204052 [details]
Patch
Comment 6 WebKit Commit Bot 2013-06-07 14:27:19 PDT 
Comment on attachment 204052 [details]
Patch

Clearing flags on attachment: 204052

Committed r151336: <http://trac.webkit.org/changeset/151336>
Comment 7 WebKit Commit Bot 2013-06-07 14:27:23 PDT 
All reviewed patches have been landed.  Closing bug.