Move computed style extraction out of CSSComputedStyleDeclaration.
Created attachment 203202 [details] Patch
Attachment 203202 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.h', u'Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp', u'Source/WebCore/rendering/style/RenderStyle.h', u'Source/WebCore/svg/SVGPaint.h']" exit_code: 1 Source/WebCore/css/CSSComputedStyleDeclaration.h:52: The parameter name "node" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 203202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203202&action=review r=me > Source/WebCore/css/CSSComputedStyleDeclaration.h:78 > + PassRefPtr<CSSValueList> getCSSPropertyValuesForShorthandProperties(const StylePropertyShorthand&) const; > + PassRefPtr<CSSValueList> getCSSPropertyValuesForSidesShorthand(const StylePropertyShorthand&) const; > + PassRefPtr<CSSValueList> getBackgroundShorthandValue() const; > + PassRefPtr<CSSValueList> getCSSPropertyValuesForGridShorthand(const StylePropertyShorthand&) const; At some point we should fix the naming to follow WebKit style. > Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:63 > -PassRefPtr<SVGPaint> CSSComputedStyleDeclaration::adjustSVGPaintForCurrentColor(PassRefPtr<SVGPaint> newPaint, RenderStyle* style) const > +PassRefPtr<SVGPaint> ComputedStyleExtractor::adjustSVGPaintForCurrentColor(PassRefPtr<SVGPaint> newPaint, RenderStyle* style) const Annoying how this is spread out to multiple files.
Committed r150901: <http://trac.webkit.org/changeset/150901>