Bug 11661 - SVG: stroke not sensitive to mouse events (hit testing fails)
Summary: SVG: stroke not sensitive to mouse events (hit testing fails)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Rob Buis
URL: http://www.carto.net/neumann/webkitsv...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-21 03:30 PST by Andreas Neumann
Modified: 2006-11-23 14:51 PST (History)
0 users

See Also:


Attachments
First attempt (1.86 KB, patch)
2006-11-22 12:29 PST, Rob Buis
eric: review-
Details | Formatted Diff | Diff
Now with testcase (19.01 KB, patch)
2006-11-22 12:46 PST, Rob Buis
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Neumann 2006-11-21 03:30:46 PST
In this example I don't get alerts when clicking on the red line or the black stroke of the rectangle. On rare occasions I get alerts on the black stroke of the rectangle, but not reliable/reproducable.

This might be related to bug http://bugs.webkit.org/show_bug.cgi?id=11096
Comment 1 Rob Buis 2006-11-21 12:23:51 PST
Hi Andreas,

So nice to see you entering svg bugs!

(In reply to comment #0)
> In this example I don't get alerts when clicking on the red line or the black
> stroke of the rectangle. On rare occasions I get alerts on the black stroke of
> the rectangle, but not reliable/reproducable.
> 
> This might be related to bug http://bugs.webkit.org/show_bug.cgi?id=11096

That one really seems different, its about unclosed polylines IIRC. I investigated this one, the
transforms/translations seem to mess it up. My bet is that it is due to the viewBox calculations. I'll
work on it!
Cheers,

Rob.
Comment 2 Rob Buis 2006-11-22 12:29:02 PST
Created attachment 11614 [details]
First attempt

This makes the testcase work and also works with the existing tests.
Cheers,

Rob.
Comment 3 Eric Seidel (no email) 2006-11-22 12:31:23 PST
Comment on attachment 11614 [details]
First attempt

This needs a test case.  (or needs to have fixed an existing one).  Otherwise it looks fine.
Comment 4 Rob Buis 2006-11-22 12:46:51 PST
Created attachment 11615 [details]
Now with testcase

MacDome correctly pointed out the patch lacked a testcase, so there :)
Cheers,

Rob.
Comment 5 Eric Seidel (no email) 2006-11-22 13:24:43 PST
Comment on attachment 11615 [details]
Now with testcase

Well, it's not the worlds simplest test case.  But assuming it failed before and now succeeds, your patch looks good!
Comment 6 David Kilzer (:ddkilzer) 2006-11-23 14:51:51 PST
rwlbuis committed r17876.