Bug 116050 - Sometimes NSUndoManager can get into an inconsistent state
Summary: Sometimes NSUndoManager can get into an inconsistent state
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 116257
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-13 11:29 PDT by Ryosuke Niwa
Modified: 2013-05-16 19:26 PDT (History)
5 users (show)

See Also:


Attachments
Fixes the bug (3.27 KB, patch)
2013-05-13 11:33 PDT, Ryosuke Niwa
buildbot: owner-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (482.94 KB, application/zip)
2013-05-13 12:39 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-05-13 11:29:26 PDT
To fix <rdar://problem/12169595>, we need to work around the bug in NSUndoManager.
Comment 1 Ryosuke Niwa 2013-05-13 11:33:36 PDT
Created attachment 201584 [details]
Fixes the bug
Comment 2 Build Bot 2013-05-13 12:39:40 PDT
Comment on attachment 201584 [details]
Fixes the bug

Attachment 201584 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/451877

New failing tests:
fast/table/table-rowspan-height-distribution-in-rows.html
editing/undo/undo-iframe-location-change.html
Comment 3 Build Bot 2013-05-13 12:39:41 PDT
Created attachment 201623 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.2
Comment 4 Ryosuke Niwa 2013-05-13 13:07:25 PDT
Committed r150034: <http://trac.webkit.org/changeset/150034>
Comment 5 Darin Adler 2013-05-13 15:55:18 PDT
Comment on attachment 201584 [details]
Fixes the bug

Enrica already reviewed this. Sorry I was mixed up.
Comment 6 WebKit Commit Bot 2013-05-16 19:26:14 PDT
Re-opened since this is blocked by bug 116257