WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115482
[BlackBerry] Expand spellcheck logging
https://bugs.webkit.org/show_bug.cgi?id=115482
Summary
[BlackBerry] Expand spellcheck logging
Nima Ghanavatian
Reported
2013-05-01 10:57:30 PDT
ssia
Attachments
Patch
(7.17 KB, patch)
2013-05-01 10:59 PDT
,
Nima Ghanavatian
no flags
Details
Formatted Diff
Diff
Patch
(6.66 KB, patch)
2013-05-06 15:06 PDT
,
Nima Ghanavatian
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1
2013-05-01 10:59:57 PDT
Created
attachment 200226
[details]
Patch
Rob Buis
Comment 2
2013-05-06 12:13:55 PDT
Comment on
attachment 200226
[details]
Patch Ok.
WebKit Commit Bot
Comment 3
2013-05-06 12:15:40 PDT
Comment on
attachment 200226
[details]
Patch Rejecting
attachment 200226
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 200226, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /WebKitSupport/SpellingHandler.cpp Hunk #1 succeeded at 13 (offset -1 lines). Hunk #2 succeeded at 68 (offset -11 lines). Hunk #3 FAILED at 81. Hunk #4 succeeded at 102 (offset -11 lines). Hunk #5 FAILED at 129. Hunk #6 FAILED at 140. 3 out of 6 hunks FAILED -- saving rejects to file Source/WebKit/blackberry/WebKitSupport/SpellingHandler.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Rob Buis']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/294105
Nima Ghanavatian
Comment 4
2013-05-06 15:06:44 PDT
Created
attachment 200818
[details]
Patch
Nima Ghanavatian
Comment 5
2013-05-06 15:07:19 PDT
patches must have applied in the wrong order causing a conflict for this one. removed the conflicting piece and updated.
Rob Buis
Comment 6
2013-05-07 08:50:24 PDT
Comment on
attachment 200818
[details]
Patch Retrying.
WebKit Commit Bot
Comment 7
2013-05-07 09:17:22 PDT
Comment on
attachment 200818
[details]
Patch Clearing flags on attachment: 200818 Committed
r149674
: <
http://trac.webkit.org/changeset/149674
>
WebKit Commit Bot
Comment 8
2013-05-07 09:17:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug