WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115236
[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115236
Summary
[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
Zan Dobersek
Reported
2013-04-26 01:33:40 PDT
[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
Attachments
Patch
(1.30 KB, patch)
2013-04-26 01:36 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch
(2.06 KB, patch)
2013-04-26 01:39 PDT
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2013-04-26 01:36:48 PDT
Created
attachment 199800
[details]
Patch
Zan Dobersek
Comment 2
2013-04-26 01:38:16 PDT
Depends on the cleanup in
bug #115233
, meaning it won't apply in EWS. Can reupload when that bug is fixed.
Zan Dobersek
Comment 3
2013-04-26 01:39:58 PDT
Created
attachment 199801
[details]
Patch
Gustavo Noronha (kov)
Comment 4
2013-04-29 06:33:36 PDT
Comment on
attachment 199801
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=199801&action=review
> Tools/TestWebKitAPI/GNUmakefile.am:85 > + $(GTK_LIBS)
This is interesting, I guess you need this since you're linking to libTestWebKitAPIMain.la, which links with stuff that uses gtk?
Zan Dobersek
Comment 5
2013-04-29 10:37:28 PDT
Comment on
attachment 199801
[details]
Patch Clearing flags on attachment: 199801 Committed
r149296
: <
http://trac.webkit.org/changeset/149296
>
Zan Dobersek
Comment 6
2013-04-29 10:37:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug