Bug 115236 - [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
Summary: [GTK] Set up the TestJavaScriptCore in TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on: 115233
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-26 01:33 PDT by Zan Dobersek
Modified: 2013-04-29 10:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2013-04-26 01:36 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (2.06 KB, patch)
2013-04-26 01:39 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-04-26 01:33:40 PDT 
[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
Comment 1 Zan Dobersek 2013-04-26 01:36:48 PDT 
Created attachment 199800 [details]
Patch
Comment 2 Zan Dobersek 2013-04-26 01:38:16 PDT 
Depends on the cleanup in bug #115233, meaning it won't apply in EWS. Can reupload when that bug is fixed.
Comment 3 Zan Dobersek 2013-04-26 01:39:58 PDT 
Created attachment 199801 [details]
Patch
Comment 4 Gustavo Noronha (kov) 2013-04-29 06:33:36 PDT 
Comment on attachment 199801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199801&action=review

> Tools/TestWebKitAPI/GNUmakefile.am:85
> +	$(GTK_LIBS)

This is interesting, I guess you need this since you're linking to libTestWebKitAPIMain.la, which links with stuff that uses gtk?
Comment 5 Zan Dobersek 2013-04-29 10:37:28 PDT 
Comment on attachment 199801 [details]
Patch

Clearing flags on attachment: 199801

Committed r149296: <http://trac.webkit.org/changeset/149296>
Comment 6 Zan Dobersek 2013-04-29 10:37:33 PDT 
All reviewed patches have been landed.  Closing bug.