WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
115168
Build fix for WinCE after
r148888
and
r149097
https://bugs.webkit.org/show_bug.cgi?id=115168
Summary
Build fix for WinCE after r148888 and r149097
Patrick R. Gansterer
Reported
2013-04-25 03:27:45 PDT
Build fix for WinCE after
r148888
and
r149097
Attachments
Patch
(2.34 KB, patch)
2013-04-25 04:12 PDT
,
Patrick R. Gansterer
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1
2013-04-25 04:12:22 PDT
Created
attachment 199648
[details]
Patch
WebKit Commit Bot
Comment 2
2013-04-25 04:14:56 PDT
Attachment 199648
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MathExtras.h']" exit_code: 1 Source/WTF/wtf/MathExtras.h:216: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2013-04-29 07:13:05 PDT
Comment on
attachment 199648
[details]
Patch Eww, but OK.
WebKit Commit Bot
Comment 4
2013-04-29 08:21:32 PDT
Comment on
attachment 199648
[details]
Patch Clearing flags on attachment: 199648 Committed
r149285
: <
http://trac.webkit.org/changeset/149285
>
WebKit Commit Bot
Comment 5
2013-04-29 08:21:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug