Bug 115168 - Build fix for WinCE after r148888 and r149097
Summary: Build fix for WinCE after r148888 and r149097
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 03:27 PDT by Patrick R. Gansterer
Modified: 2013-04-29 08:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2013-04-25 04:12 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-04-25 03:27:45 PDT
Build fix for WinCE after r148888 and r149097
Comment 1 Patrick R. Gansterer 2013-04-25 04:12:22 PDT
Created attachment 199648 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-25 04:14:56 PDT
Attachment 199648 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MathExtras.h']" exit_code: 1
Source/WTF/wtf/MathExtras.h:216:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-04-29 07:13:05 PDT
Comment on attachment 199648 [details]
Patch

Eww, but OK.
Comment 4 WebKit Commit Bot 2013-04-29 08:21:32 PDT
Comment on attachment 199648 [details]
Patch

Clearing flags on attachment: 199648

Committed r149285: <http://trac.webkit.org/changeset/149285>
Comment 5 WebKit Commit Bot 2013-04-29 08:21:34 PDT
All reviewed patches have been landed.  Closing bug.