Bug 11494 - [CSS 3] support for vertical-text, cell and context-menu cursors
Summary: [CSS 3] support for vertical-text, cell and context-menu cursors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Nobody
URL: http://naesbye.gigahost.dk/index.php?...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-02 09:33 PST by Lars Næsbye Christensen
Modified: 2006-11-11 07:25 PST (History)
0 users

See Also:


Attachments
adds support for 3 selectors from CSS 3 cursor style specs (10.42 KB, patch)
2006-11-02 09:34 PST, Lars Næsbye Christensen
sam: review-
Details | Formatted Diff | Diff
Patch for 3 more cursor styles from CSS 3 specs (10.42 KB, patch)
2006-11-02 17:49 PST, Lars Næsbye Christensen
timothy: review-
Details | Formatted Diff | Diff
Testcase : Shows CSS cursor selectors (3.28 KB, text/html)
2006-11-04 19:37 PST, Lars Næsbye Christensen
no flags Details
updated to include ChangeLog entry and cleaned up (10.88 KB, patch)
2006-11-04 19:38 PST, Lars Næsbye Christensen
mjs: review-
Details | Formatted Diff | Diff
revised - now with edited testcase in manual-tests (11.87 KB, patch)
2006-11-08 17:33 PST, Lars Næsbye Christensen
mitz: review-
Details | Formatted Diff | Diff
yet another revision of the previous patch (11.94 KB, patch)
2006-11-11 04:29 PST, Lars Næsbye Christensen
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Næsbye Christensen 2006-11-02 09:33:36 PST
Third patch in the project to achieve CSS3 cursor-style support. This adds the vertical-text, cell and context-menu.
Comment 1 Lars Næsbye Christensen 2006-11-02 09:34:54 PST
Created attachment 11348 [details]
adds support for 3 selectors from CSS 3 cursor style specs
Comment 2 Sam Weinig 2006-11-02 14:34:27 PST
Comment on attachment 11348 [details]
adds support for 3 selectors from CSS 3 cursor style specs

Looks good but it needs a Changelog and a Layout test.  r- for now.
Comment 3 Lars Næsbye Christensen 2006-11-02 16:13:02 PST
Adds support for more values in the CSS 3 cursor style property: vertical-text, cell and context-menu.
Third patch towards support of all 32 values.

NB : Apple discourages the use of the 'plus' cursor, but I expect this is the API, not the graphic. A prettier graphic might be added later as part of a unified consistent suite , this is just basic support.
Comment 4 Lars Næsbye Christensen 2006-11-02 17:49:53 PST
Created attachment 11357 [details]
Patch for 3 more cursor styles from CSS 3 specs

Adds support for more values in the CSS 3 cursor style property: vertical-text,
cell and context-menu. 3rd patch of 5 towards support of all 32 values.

Apple discourages the use of the 'plus' cursor, but I expect this is the
API, not the graphic. A prettier graphic might be added later as part of a
unified consistent suite of cursor images, this is just basic support using a legacy image.
Comment 5 Timothy Hatcher 2006-11-03 08:20:13 PST
Comment on attachment 11357 [details]
Patch for 3 more cursor styles from CSS 3 specs

Actually this still needs a ChangeLog and a test case.

You can use prepare-ChangeLog to do this.
Comment 6 Lars Næsbye Christensen 2006-11-04 19:37:20 PST
Created attachment 11384 [details]
Testcase : Shows CSS cursor selectors
Comment 7 Lars Næsbye Christensen 2006-11-04 19:38:45 PST
Created attachment 11385 [details]
updated to include ChangeLog entry and cleaned up

Hope this does it, then :-P
Comment 8 Maciej Stachowiak 2006-11-05 19:26:43 PST
Comment on attachment 11385 [details]
updated to include ChangeLog entry and cleaned up

Please fix the email address in the ChangeLog entry. Also it's strongly preferred to include the test case in the patch itself (in WebCore/manual-tests if it's not easily automatable).
Comment 9 Lars Næsbye Christensen 2006-11-08 17:33:15 PST
Created attachment 11436 [details]
revised - now with edited testcase in manual-tests

OK, now I hope it's allright, then. There was a test case, which I just modified.
Comment 10 mitz 2006-11-10 14:56:07 PST
Comment on attachment 11436 [details]
revised - now with edited testcase in manual-tests

The ChangeLog entry should include this bug's URL and description. See other ChangeLog entries for example. Also, please add a newline at the end of the test. r- for now because of the ChangeLog.
Comment 11 Lars Næsbye Christensen 2006-11-11 04:29:07 PST
Created attachment 11481 [details]
yet another revision of the previous patch

fix0r
Comment 12 Alexey Proskuryakov 2006-11-11 07:01:31 PST
Comment on attachment 11481 [details]
yet another revision of the previous patch

r=me
Comment 13 Alexey Proskuryakov 2006-11-11 07:25:00 PST
Committed revision 17728.