Bug 114918 - [SOUP] libsoup 2.42.0 regressions
Summary: [SOUP] libsoup 2.42.0 regressions
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-21 10:28 PDT by Chris Dumez
Modified: 2017-03-11 10:47 PST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-21 10:28:50 PDT
http/tests/xmlhttprequest/cache-override.html is flaky on EFL WK2 with the following diff:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/http/tests/xmlhttprequest/cache-override-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/http/tests/xmlhttprequest/cache-override-actual.txt
@@ -6,23 +6,23 @@
 If-MODIFIED-Since override: status = 304
 If-Modified-Since override (modified): status = 200
 If-Unmodified-Since override: status = 200
-If-Unmodified-Since override (modified): status = 412
+If-Unmodified-Since override (modified): status = 200
 If-Match override: status = 200
-If-Match override (none match): status = 412
+If-Match override (none match): status = 200
 If-None-Match override: status = 304
 If-None-Match override (none match): status = 200
-If-Range override: status = 206
+If-Range override: status = 200
 If-Range override (none match): status = 200
 If-Modified-Since override (uncached response): status = 304
 async: Automatically cached response body is correct; status = 200
 async: If-Modified-Since override: status = 304
 async: If-Modified-Since override (modified): status = 200
 async: If-Unmodified-Since override: status = 200
-async: If-Unmodified-Since override (modified): status = 412
+async: If-Unmodified-Since override (modified): status = 200
 async: If-Match override: status = 200
-async: If-Match override (none match): status = 412
+async: If-Match override (none match): status = 200
 async: If-None-Match override: status = 304
 async: If-None-Match override (none match): status = 200
-async: If-Range override: status = 206
+async: If-Range override: status = 200
 async: If-Range override (none match): status = 200
 async: If-Modified-Since override (uncached response): status = 304
Comment 1 Chris Dumez 2013-04-21 10:29:31 PDT
http/tests/xmlhttprequest/range-test.html is flaky as well and the issue seems related:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/http/tests/xmlhttprequest/range-test-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/http/tests/xmlhttprequest/range-test-actual.txt
@@ -1,9 +1,11 @@
 Test Range support in XMLHttpRequest
 
 getRange(resources/reply.xml, 34, 36, false)
-Length : expected 2 got 2
+Expected a 206 response, got 200
+Length : expected 2 got 68
 getRange(resources/reply.xml, 35, 38, false)
-Length : expected 3 got 3
+Expected a 206 response, got 200
+Length : expected 3 got 68
 getRange(resources/reply.xml, 34, 36, true)
 Length : expected 2 got 2
 getRange(resources/reply.xml, 35, 38, true)
Comment 2 Chris Dumez 2013-04-21 10:41:42 PDT
It appears those started failing after libsoup was bumped to 2.42.0.

The following tests are failing as well:
 http/tests/cache/reload-main-resource.php
 http/tests/cache/xhr-vary-header.html
Comment 3 Dan Winship 2013-04-22 07:12:52 PDT
It seems strange that these would fail on EFL but not GTK if it was related to the new version of libsoup. Did you change anything else in WebKit when you bumped the libsoup requirement?
Comment 4 Sergio Villar Senin 2013-04-22 07:41:46 PDT
Regarding the cache-override.html test the reason could be the following. The libsoup cache normally bypasses conditional requests issued by the client, which is correct, but in order to identify them it only currently checks "If-Modified-Since" and "If-None-Match". We need to add "If-Unmodified-Since" and "If-Match" to the list.

Maybe this test was recently removed from the skipped list or something because this issue in the cache has been there since the very beginning.
Comment 5 Manuel Rego Casasnovas 2013-04-24 02:36:08 PDT
I've been testing these tests in the GTK port and they were failing exactly the same with libsoup 2.40.0 and without the patch removing the deprecated API so the issue seems unrelated with the bump and the removal of deprecated API.

For example the issue with test "http/tests/cache/xhr-vary-header.html" has been already reported in bug #89278.
Comment 6 Jinwoo Song 2013-09-06 22:07:12 PDT
Removed following tests from EFL test expectation in http://trac.webkit.org/changeset/155236 since the test has been passing.
 http/tests/cache/reload-main-resource.php
 http/tests/cache/xhr-vary-header.html