Bug 114846 - Remove unmaintained feature REQUEST_AUTOCOMPLETE
Summary: Remove unmaintained feature REQUEST_AUTOCOMPLETE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Beam
URL:
Keywords:
Depends on:
Blocks: 100560
  Show dependency treegraph
 
Reported: 2013-04-18 21:13 PDT by Dan Beam
Modified: 2013-04-19 01:39 PDT (History)
10 users (show)

See Also:


Attachments
Patch (32.31 KB, patch)
2013-04-18 21:21 PDT, Dan Beam
no flags Details | Formatted Diff | Diff
forgot some expectations (35.08 KB, patch)
2013-04-18 21:38 PDT, Dan Beam
no flags Details | Formatted Diff | Diff
merge (35.10 KB, patch)
2013-04-19 00:04 PDT, Dan Beam
no flags Details | Formatted Diff | Diff
removing OOPS! (35.06 KB, patch)
2013-04-19 00:11 PDT, Dan Beam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Beam 2013-04-18 21:13:23 PDT
Because HTMLFormElement#requestAutocomplete() was only used by the now removed Chromium port, its code should be deleted from WebKit to reduce code complexity and to speed up test time, pre-processing/compilation, and checkout times.
Comment 1 Dan Beam 2013-04-18 21:21:12 PDT
Created attachment 198793 [details]
Patch
Comment 2 Dan Beam 2013-04-18 21:38:40 PDT
Created attachment 198794 [details]
forgot some expectations
Comment 3 Kent Tamura 2013-04-18 22:54:18 PDT
Comment on attachment 198794 [details]
forgot some expectations

looks ok
Comment 4 WebKit Commit Bot 2013-04-18 23:51:44 PDT
Comment on attachment 198794 [details]
forgot some expectations

Rejecting attachment 198794 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 198794, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   72ebac6..17aafb0  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 148722 = 72ebac6aad6a24b631d7d29f2b14a1b3dc3d6245
r148723 = 17aafb03f77f30745e12e56865f0970089735641
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/25171
Comment 5 Dan Beam 2013-04-19 00:04:49 PDT
Created attachment 198815 [details]
merge
Comment 6 Kent Tamura 2013-04-19 00:08:56 PDT
Comment on attachment 198815 [details]
merge

View in context: https://bugs.webkit.org/attachment.cgi?id=198815&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please remove OOPS!
Comment 7 Dan Beam 2013-04-19 00:11:38 PDT
Created attachment 198817 [details]
removing OOPS!
Comment 8 Dan Beam 2013-04-19 00:12:05 PDT
Comment on attachment 198815 [details]
merge

View in context: https://bugs.webkit.org/attachment.cgi?id=198815&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests (OOPS!).
> 
> Please remove OOPS!

Done.
Comment 9 Kent Tamura 2013-04-19 00:12:34 PDT
Comment on attachment 198817 [details]
removing OOPS!

ok
Comment 10 WebKit Commit Bot 2013-04-19 01:39:45 PDT
Comment on attachment 198817 [details]
removing OOPS!

Clearing flags on attachment: 198817

Committed r148731: <http://trac.webkit.org/changeset/148731>
Comment 11 WebKit Commit Bot 2013-04-19 01:39:49 PDT
All reviewed patches have been landed.  Closing bug.