Bug 114694 - [Windows, WinCairo] Remove Include Settings for Pthreads from WTF
Summary: [Windows, WinCairo] Remove Include Settings for Pthreads from WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 114563
Blocks:
  Show dependency tree / graph
 
Reported: 2013-04-16 12:24 PDT by Brent Fulgham
Modified: 2013-04-17 11:57 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.49 KB, patch)
2013-04-17 11:55 PDT, Brent Fulgham 		rniwa: review+
rniwa: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-04-16 12:24:08 PDT 
Now that WTF is clean of pthread use under Windows, remove the project settings and include paths for pthreads.

This change will allow JavaScriptCoreExportGenerator (VS2010) and WebKitExportGenerator (VS2005 and VS2010) to build and run without needing pthreads.

It will also allow builds under VS2010 to run cleanly on the build bots, since we will no longer have to deal with the Windows SxS error related to the pthreads.dll shipped as part of the Apple "Common Files" distribution.  This had prevented us from using VS2010 builds on the build bots.
Comment 1 Brent Fulgham 2013-04-17 11:55:22 PDT 
Created attachment 198591 [details]
Patch
Comment 2 Brent Fulgham 2013-04-17 11:57:02 PDT 
Committed r148623: <http://trac.webkit.org/changeset/148623>