Bug 114687 - AX: VoiceOver says everything that isn't a link is a "clickable" in Safari reader?
Summary: AX: VoiceOver says everything that isn't a link is a "clickable" in Safari re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 09:33 PDT by chris fleizach
Modified: 2013-04-17 17:36 PDT (History)
5 users (show)

See Also:


Attachments
patch (7.33 KB, patch)
2013-04-16 09:40 PDT, chris fleizach
thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-04-16 09:33:52 PDT
VoiceOver is saying everything in Safari reader is clickable.

That's because the AXPress action is exposed on all static text elements

That's happening because on the <body> tag there's an on click handler

I think the best course of action is not to expose AXPress for static text elements if the on click handler is on the body.
Comment 1 chris fleizach 2013-04-16 09:40:50 PDT
Created attachment 198337 [details]
patch
Comment 2 Tim Horton 2013-04-17 09:24:34 PDT
Comment on attachment 198337 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=198337&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:966
> +        // It can cause false positives where every piece of text is labeled as accepting press actions when

this comment looks cut off.
Comment 3 Tim Horton 2013-04-17 09:32:27 PDT
Comment on attachment 198337 [details]
patch

But other than that it seems fine.
Comment 4 chris fleizach 2013-04-17 17:36:10 PDT
Thanks. Fixed the comment

http://trac.webkit.org/changeset/148652