Bug 114668 - Move webkitpy.layout_tests.port to webkitpy.port
Summary: Move webkitpy.layout_tests.port to webkitpy.port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 01:06 PDT by Ryosuke Niwa
Modified: 2013-04-16 02:08 PDT (History)
5 users (show)

See Also:

Attachments
Move webkitpy.layout_tests.port to webkitpy.port (460.21 KB, patch)
2013-04-16 01:08 PDT, Ryosuke Niwa 		mjs: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-04-16 01:06:57 PDT 
Move webkitpy.layout_tests.port to webkitpy.port
Comment 1 Ryosuke Niwa 2013-04-16 01:08:07 PDT 
Created attachment 198272 [details]
Move webkitpy.layout_tests.port to webkitpy.port
Comment 2 Maciej Stachowiak 2013-04-16 01:15:16 PDT 
Comment on attachment 198272 [details]
Move webkitpy.layout_tests.port to webkitpy.port

rs=me
Comment 3 Ryosuke Niwa 2013-04-16 01:34:45 PDT 
Committed r148502: <http://trac.webkit.org/changeset/148502>
Comment 4 Csaba Osztrogonác 2013-04-16 02:07:20 PDT 
This patch killed the Qt EWS with the following error message and it 
needed manual kick:

ImportError: No module named port.factory
rm: cannot remove `qt-ews.log': No such file or directory
fatal: ambiguous argument 'trunk': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions
Not removing Tools/Scripts/webkitpy/layout_tests/port/
No rebase in progress?
Tools/ChangeLog: needs update
Tools/Scripts/webkitpy/common/host.py: needs update
Tools/Scripts/webkitpy/common/host_mock.py: needs update
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: needs update
Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: needs update
Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: needs update
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: needs update
Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py: needs update
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: needs update
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: needs update
Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: needs update
Tools/Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: needs update
Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py: needs update
Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py: needs update
Tools/Scripts/webkitpy/performance_tests/perftest.py: needs update
Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py: needs update
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: needs update
Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: needs update
Tools/Scripts/webkitpy/tool/bot/botinfo_unittest.py: needs update
Tools/Scripts/webkitpy/tool/commands/gardenomatic.py: needs update
Tools/Scripts/webkitpy/tool/commands/perfalizer_unittest.py: needs update
Tools/Scripts/webkitpy/tool/commands/queries.py: needs update
Tools/Scripts/webkitpy/tool/commands/queries_unittest.py: needs update
Tools/Scripts/webkitpy/tool/commands/rebaseline.py: needs update
Tools/Scripts/webkitpy/tool/servers/gardeningserver.py: needs update
Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: needs update
Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py: needs update
Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py: needs update
update-index --refresh: command returned error: 1

Traceback (most recent call last):
  File "/home/webkit/WebKit/Tools/Scripts/webkitpy/test/main.py", line 39, in <module>
    from webkitpy.test.runner import Runner, unit_test_name
  File "/home/webkit/WebKit/Tools/Scripts/webkitpy/test/runner.py", line 29, in <module>
    from webkitpy.common import message_pool
  File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 52, in <module>
    from webkitpy.common.host import Host
  File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/host.py", line 40, in <module>
    from webkitpy.port.factory import PortFactory
ImportError: No module named port.factory
Traceback (most recent call last):
  File "./Tools/Scripts/webkit-patch", line 44, in <module>
    from webkitpy.tool.main import WebKitPatch
  File "/home/webkit/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module>
    from webkitpy.common.host import Host
  File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/host.py", line 40, in <module>
    from webkitpy.port.factory import PortFactory
ImportError: No module named port.factory
rm: cannot remove `qt-ews.log': No such file or directory
fatal: ambiguous argument 'trunk': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions

...

It would be great if we can fix https://bugs.webkit.org/show_bug.cgi?id=97647 once ....
Comment 5 Ryosuke Niwa 2013-04-16 02:08:46 PDT 
Yeah, the problem appears to be that this patch didn’t apply cleaningly :( So it applied half way through and when EWS tried to unapply, it choked on that module.