Bug 114409 - Merge CharacterClassTable into CharacterClass
Summary: Merge CharacterClassTable into CharacterClass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-10 20:34 PDT by Benjamin Poulain
Modified: 2013-04-11 20:44 PDT (History)
0 users

See Also:


Attachments
Patch (6.60 KB, patch)
2013-04-10 20:39 PDT, Benjamin Poulain
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-04-10 20:34:55 PDT
Merge CharacterClassTable into CharacterClass
Comment 1 Benjamin Poulain 2013-04-10 20:39:46 PDT
Created attachment 197501 [details]
Patch
Comment 2 Darin Adler 2013-04-11 10:51:02 PDT
Comment on attachment 197501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197501&action=review

> Source/JavaScriptCore/yarr/YarrPattern.cpp:180
> +        OwnPtr<CharacterClass> characterClass = adoptPtr(new CharacterClass());

I like omitting the () in cases like this.
Comment 3 Benjamin Poulain 2013-04-11 20:44:23 PDT
Committed r148259: <http://trac.webkit.org/changeset/148259>