Bug 114351 - Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
Summary: Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 67400
  Show dependency tree / graph
 
Reported: 2013-04-10 04:09 PDT by Patrick R. Gansterer
Modified: 2013-04-10 20:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2013-04-10 04:13 PDT, Patrick R. Gansterer 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-04-10 04:09:47 PDT 
Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
Comment 1 Patrick R. Gansterer 2013-04-10 04:13:03 PDT 
Created attachment 197244 [details]
Patch
Comment 2 WebKit Commit Bot 2013-04-10 19:41:56 PDT 
Comment on attachment 197244 [details]
Patch

Rejecting attachment 197244 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--non-interactive', 197244, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-commit-queue.appspot.com/results/17746023
Comment 3 Patrick R. Gansterer 2013-04-10 20:54:50 PDT 
Committed r148170: <http://trac.webkit.org/changeset/148170>