Bug 114176 - Rollout r147756: performance regression
Summary: Rollout r147756: performance regression
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
URL: https://bugs.webkit.org/show_bug.cgi?...
Keywords:
: 114241 (view as bug list)
Depends on:
Blocks: 74144
  Show dependency tree / graph
 
Reported: 2013-04-08 10:33 PDT by Mihai Maerean
Modified: 2013-06-14 06:00 PDT (History)
15 users (show)

See Also:

Attachments
patch (22.77 KB, patch)
2013-04-08 12:46 PDT, Mihai Maerean 		menard: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (22.69 KB, patch)
2013-04-08 21:58 PDT, Mihai Maerean 		no flags Details | Formatted Diff | Diff
patch for landing. (22.68 KB, patch)
2013-04-08 22:29 PDT, Mihai Maerean 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Maerean 2013-04-08 10:33:00 PDT 
Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 [CSS Regions] Elements in a region should be assignable to a named flow
Comment 1 Mihai Maerean 2013-04-08 12:46:15 PDT 
Created attachment 196883 [details]
patch
Comment 2 WebKit Commit Bot 2013-04-08 13:59:38 PDT 
Comment on attachment 196883 [details]
patch

Rejecting attachment 196883 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 196883, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   56fe78a..b6eb305  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 147948 = 56fe78af28aab2a91fe5a11350078b4c6fe84eae
r147949 = b6eb305b6c07444b5ff297286727dfa8514499a7
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-commit-queue.appspot.com/results/17558046
Comment 3 Thiago Marcos P. Santos 2013-04-08 14:46:28 PDT 
Comment on attachment 196883 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196883&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

This patch won't land because of this OOPS here.
Comment 4 Mihai Maerean 2013-04-08 21:58:38 PDT 
Created attachment 196994 [details]
patch

Removes the OOPS!. Explains that there are no new tests because this is a rollout patch.
Comment 5 Mihai Maerean 2013-04-08 22:25:36 PDT 
Comment on attachment 196994 [details]
patch

have to manually write the reviewer's name in the change log.
Comment 6 Mihai Maerean 2013-04-08 22:29:07 PDT 
Created attachment 196998 [details]
patch for landing.

change log contains the reviewer's name.
Comment 7 Ryosuke Niwa 2013-04-08 22:29:25 PDT 
*** Bug 114241 has been marked as a duplicate of this bug. ***
Comment 8 WebKit Commit Bot 2013-04-08 23:14:43 PDT 
Comment on attachment 196998 [details]
patch for landing.

Clearing flags on attachment: 196998

Committed r147983: <http://trac.webkit.org/changeset/147983>