Bug 114127 - Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
Summary: Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
: 114125 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-04-07 12:04 PDT by Patrick R. Gansterer
Modified: 2013-04-07 16:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2013-04-07 12:09 PDT, Patrick R. Gansterer 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-04-07 12:04:03 PDT 
Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
Comment 1 Patrick R. Gansterer 2013-04-07 12:09:38 PDT 
Created attachment 196797 [details]
Patch
Comment 2 Benjamin Poulain 2013-04-07 14:26:46 PDT 
Comment on attachment 196797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196797&action=review

> Source/WTF/ChangeLog:9
> +        Platform.h defines WTF_ARM_ARCH_VERSION always and removing the
> +        check works around a bug in older Microsoft compiler versions.

Please fix the changelog.
Comment 3 Patrick R. Gansterer 2013-04-07 15:07:19 PDT 
Committed r147881: <http://trac.webkit.org/changeset/147881>
Comment 4 Patrick R. Gansterer 2013-04-07 16:28:45 PDT 
*** Bug 114125 has been marked as a duplicate of this bug. ***