Bug 113794 - [GTK] WebKitWebNavigationAction: dispose and finalize mixed up
Summary: [GTK] WebKitWebNavigationAction: dispose and finalize mixed up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 09:18 PDT by Alban Crequy
Modified: 2013-04-03 08:16 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] WebKitWebNavigationAction: fix mix between dispose and finalize (1.07 KB, patch)
2013-04-02 09:18 PDT, Alban Crequy 		gustavo: review-
Details | Formatted Diff | Diff
[PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize (2.40 KB, patch)
2013-04-03 06:07 PDT, Alban Crequy 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alban Crequy 2013-04-02 09:18:50 PDT 
Created attachment 196158 [details]
[PATCH] WebKitWebNavigationAction: fix mix between dispose and finalize

WebKitWebNavigationAction's dispose function calls the parent's finalize function. It causes a segfault in some scenarios.

I am testing the attached patch.
Comment 1 Alban Crequy 2013-04-03 01:37:16 PDT 
The patch fixes the crash for me.
Comment 2 Gustavo Noronha (kov) 2013-04-03 05:40:59 PDT 
Comment on attachment 196158 [details]
[PATCH] WebKitWebNavigationAction: fix mix between dispose and finalize

Patch looks good, you need a ChangeLog entry, though: http://www.webkit.org/coding/contributing.html
Comment 3 Alban Crequy 2013-04-03 06:07:53 PDT 
Created attachment 196336 [details]
[PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize

patch updated with:
- a changelog
- changelog in the commit log too
Comment 4 Gustavo Noronha (kov) 2013-04-03 06:17:38 PDT 
Comment on attachment 196336 [details]
[PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize

Good to go, I'll wait for EWS and set cq+
Comment 5 WebKit Review Bot 2013-04-03 08:16:33 PDT 
Comment on attachment 196336 [details]
[PATCH] [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize

Clearing flags on attachment: 196336

Committed r147557: <http://trac.webkit.org/changeset/147557>
Comment 6 WebKit Review Bot 2013-04-03 08:16:35 PDT 
All reviewed patches have been landed.  Closing bug.