Bug 113721 - [WK2] NetworkProcess still needs to implement a sync version of shouldUseCredentialStorage
Summary: [WK2] NetworkProcess still needs to implement a sync version of shouldUseCred...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-01 14:00 PDT by Alexey Proskuryakov
Modified: 2013-04-01 14:10 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (5.05 KB, patch)
2013-04-01 14:03 PDT, Alexey Proskuryakov 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-04-01 14:00:26 PDT 
ResourceHandleMac uses shouldUseCredentialStorage internally. It's not a real problem for NetworkProcess, as it doesn't have to do IPC to reply, although it of course breaks the model somewhat.
Comment 1 Alexey Proskuryakov 2013-04-01 14:03:44 PDT 
Created attachment 196020 [details]
proposed fix
Comment 2 WebKit Review Bot 2013-04-01 14:06:27 PDT 
Attachment 196020 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2013-04-01 14:10:53 PDT 
Committed <http://trac.webkit.org/changeset/147359>.