Bug 113604 - [Mac] Some ligatures are applied across different fonts
Summary: [Mac] Some ligatures are applied across different fonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 114482
  Show dependency tree / graph
 
Reported: 2013-03-29 13:37 PDT by Ryosuke Niwa
Modified: 2013-04-12 09:52 PDT (History)
4 users (show)

See Also:

Attachments
Work in progress 1 (1.33 KB, patch)
2013-03-29 13:53 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64 (809.82 KB, application/zip)
2013-03-29 15:17 PDT, WebKit Review Bot 		no flags Details
Fixes the bug, unfortunately without a test (2.47 KB, patch)
2013-04-11 17:41 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-03-29 13:37:37 PDT 
We apply ligatures across different fonts in WidthIterator::advanceInternal under certain circumstances.

<rdar://problem/12656747>
Comment 1 Ryosuke Niwa 2013-03-29 13:53:49 PDT 
Created attachment 195794 [details]
Work in progress 1
Comment 2 WebKit Review Bot 2013-03-29 15:17:55 PDT 
Comment on attachment 195794 [details]
Work in progress 1

Attachment 195794 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17359062

New failing tests:
fast/text/atsui-no-ligatures-at-font-boundary.html
Comment 3 WebKit Review Bot 2013-03-29 15:17:58 PDT 
Created attachment 195809 [details]
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 4 Alexey Proskuryakov 2013-03-29 16:04:23 PDT 
Is this the same as bug 112092? Please dupe if so.

See also bug 6148.
Comment 5 Ryosuke Niwa 2013-03-29 16:30:41 PDT 
(In reply to comment #4)
> Is this the same as bug 112092? Please dupe if so.

I don't think so.
Comment 6 Ryosuke Niwa 2013-04-11 17:41:12 PDT 
Created attachment 197703 [details]
Fixes the bug, unfortunately without a test
Comment 7 WebKit Commit Bot 2013-04-12 09:52:38 PDT 
Comment on attachment 197703 [details]
Fixes the bug, unfortunately without a test

Clearing flags on attachment: 197703

Committed r148283: <http://trac.webkit.org/changeset/148283>
Comment 8 WebKit Commit Bot 2013-04-12 09:52:40 PDT 
All reviewed patches have been landed.  Closing bug.