Bug 113416 - [BlackBerry] Show compositing on the Inspector timeline properly
Summary: [BlackBerry] Show compositing on the Inspector timeline properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konrad Piascik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 09:03 PDT by Konrad Piascik
Modified: 2013-03-27 17:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2013-03-27 09:22 PDT, Konrad Piascik 		no flags Details | Formatted Diff | Diff
Patch (1.81 KB, patch)
2013-03-27 09:31 PDT, Konrad Piascik 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Piascik 2013-03-27 09:03:41 PDT 
[BlackBerry] Show compositing on the Inspector timeline properly
Comment 1 Konrad Piascik 2013-03-27 09:22:21 PDT 
Created attachment 195340 [details]
Patch
Comment 2 Rob Buis 2013-03-27 09:28:07 PDT 
Comment on attachment 195340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195340&action=review

Commit message can be improved upon.

> Source/WebKit/blackberry/ChangeLog:8
> +        Change the call to willComposite to the correct location

This seems a bit terse, and won't make clear why the change was needed when looking at this patch later.
Comment 3 Konrad Piascik 2013-03-27 09:31:01 PDT 
Created attachment 195342 [details]
Patch
Comment 4 Rob Buis 2013-03-27 10:15:41 PDT 
Comment on attachment 195342 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2013-03-27 17:16:22 PDT 
Comment on attachment 195342 [details]
Patch

Clearing flags on attachment: 195342

Committed r147032: <http://trac.webkit.org/changeset/147032>
Comment 6 WebKit Review Bot 2013-03-27 17:16:25 PDT 
All reviewed patches have been landed.  Closing bug.