Bug 113381 - Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCode is added.
Summary: Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCod...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 02:51 PDT by Vsevolod Vlasov
Modified: 2013-03-27 07:36 PDT (History)
10 users (show)

See Also:


Attachments
Patch (31.16 KB, patch)
2013-03-27 05:18 PDT, Vsevolod Vlasov
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64 (1.18 MB, application/zip)
2013-03-27 05:51 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2013-03-27 02:51:54 PDT
Breakpoint manager now restores breakpoints on UISourceCodeAdded event.
Breakpoint manager now only resets breakpoints in debugger when source mapping is changed to/from non identity one.
Comment 1 Vsevolod Vlasov 2013-03-27 05:18:24 PDT
Created attachment 195286 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-27 05:51:18 PDT
Comment on attachment 195286 [details]
Patch

Attachment 195286 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17297373

New failing tests:
http/tests/inspector/appcache/appcache-iframe-manifests.html
http/tests/inspector/injected-script-for-origin.html
http/tests/inspector/extensions-network-redirect.html
http/tests/cache/subresource-failover-to-network.html
http/tests/inspector/change-iframe-src.html
http/tests/inspector/compiler-source-mapping-debug.html
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/console-resource-errors.html
http/tests/inspector/extensions-headers.html
http/tests/inspector-enabled/injected-script-discard.html
http/tests/inspector/console-cross-origin-iframe-logging.html
http/tests/inspector/extensions-useragent.html
http/tests/inspector/extensions-iframe-eval.html
http/tests/inspector-enabled/dynamic-scripts.html
http/tests/inspector/stylesheet-source-mapping.html
http/tests/inspector-enabled/console-exception-while-no-inspector.html
http/tests/inspector/console-cd-completions.html
http/tests/inspector/compiler-script-mapping.html
http/tests/inspector/modify-cross-domain-rule.html
http/tests/inspector/web-socket-frame-error.html
http/tests/inspector/console-xhr-logging.html
http/tests/inspector/console-xhr-logging-async.html
http/tests/inspector/console-cd.html
http/tests/inspector/resource-har-headers.html
http/tests/inspector/network-preflight-options.html
http/tests/inspector/inspect-iframe-from-different-domain.html
http/tests/inspector-enabled/console-log-before-frame-navigation.html
http/tests/inspector-enabled/dom-storage-open.html
http/tests/inspector/resource-parameters.html
http/tests/inspector-enabled/database-open.html
Comment 3 WebKit Review Bot 2013-03-27 05:51:22 PDT
Created attachment 195291 [details]
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01  Port: chromium-linux-x86_64  Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment 4 Pavel Feldman 2013-03-27 07:01:16 PDT
Comment on attachment 195286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195286&action=review

> Source/WebCore/inspector/front-end/BreakpointManager.js:133
> +        var isIdentityChanged = /** @type {WebInspector.UISourceCode} */ (event.data.isIdentityChanged);

Poor cast.

> Source/WebCore/inspector/front-end/UISourceCode.js:670
> +        data.isIdentityChanged = data.isIdentity !== wasIdentity;

identityHasChanged
Comment 5 Vsevolod Vlasov 2013-03-27 07:36:01 PDT
Committed r146983: <http://trac.webkit.org/changeset/146983>