Split FilterEffectRenderer 
https://bugs.webkit.org/show_bug.cgi?id=113186
Summary Split FilterEffectRenderer
Allan Sandfeld Jensen
Reported 2013-03-25 04:44:06 PDT
The software fallback for TextureMapper (Accelerated compositing), needs to apply filter effects in software like FilterEffectRenderer applies it on RenderLayer. To make this possible without calling renderer code from the graphics backend, FilterEffectRenderer should be split into a generic part for applying software filter effect, and a part that contains the Render-tree and DOM specific parts that shouldn't be used from the graphics backend.
Attachments
Patch (40.07 KB, patch)
2013-03-25 04:55 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (40.18 KB, patch)
2013-03-25 05:29 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (45.92 KB, patch)
2013-03-25 07:17 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (43.61 KB, patch)
2013-03-28 06:37 PDT, Allan Sandfeld Jensen 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-03-25 04:55:06 PDT
Created attachment 194827 [details] Patch
Early Warning System Bot
Comment 2 2013-03-25 05:02:12 PDT
Comment on attachment 194827 [details] Patch Attachment 194827 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17232624
Early Warning System Bot
Comment 3 2013-03-25 05:03:13 PDT
Comment on attachment 194827 [details] Patch Attachment 194827 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17291219
WebKit Review Bot
Comment 4 2013-03-25 05:16:47 PDT
Comment on attachment 194827 [details] Patch Attachment 194827 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17241369
Allan Sandfeld Jensen
Comment 5 2013-03-25 05:29:48 PDT
Created attachment 194833 [details] Patch Correct merge mistake
Build Bot
Comment 6 2013-03-25 06:07:43 PDT
Comment on attachment 194833 [details] Patch Attachment 194833 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17324019
Build Bot
Comment 7 2013-03-25 06:09:48 PDT
Comment on attachment 194833 [details] Patch Attachment 194833 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17294182
Noam Rosenthal
Comment 8 2013-03-25 07:17:32 PDT
Created attachment 194848 [details] Patch
Build Bot
Comment 9 2013-03-25 07:25:00 PDT
Comment on attachment 194848 [details] Patch Attachment 194848 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17246414
Build Bot
Comment 10 2013-03-25 10:15:13 PDT
Comment on attachment 194848 [details] Patch Attachment 194848 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17329042
Allan Sandfeld Jensen
Comment 11 2013-03-28 06:37:35 PDT
Created attachment 195556 [details] Patch
WebKit Review Bot
Comment 12 2013-03-28 06:45:20 PDT
Comment on attachment 195556 [details] Patch Attachment 195556 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17257542
Build Bot
Comment 13 2013-03-28 06:51:30 PDT
Comment on attachment 195556 [details] Patch Attachment 195556 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17330315
WebKit Review Bot
Comment 14 2013-03-28 06:56:15 PDT
Comment on attachment 195556 [details] Patch Attachment 195556 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17330319
Peter Beverloo (cr-android ews)
Comment 15 2013-03-28 07:01:15 PDT
Comment on attachment 195556 [details] Patch Attachment 195556 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17296438
Allan Sandfeld Jensen
Comment 16 2013-03-28 07:06:57 PDT
Comment on attachment 195556 [details] Patch Needs rebase.
Build Bot
Comment 17 2013-03-29 11:41:52 PDT
Comment on attachment 195556 [details] Patch Attachment 195556 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17370027
Note You need to log in before you can comment on or make changes to this bug.