Bug 113186 - Split FilterEffectRenderer
Summary: Split FilterEffectRenderer
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks: 68469 113040
  Show dependency tree / graph
 
Reported: 2013-03-25 04:44 PDT by Allan Sandfeld Jensen
Modified: 2014-03-02 09:09 PST (History)
13 users (show)

See Also:

Attachments
Patch (40.07 KB, patch)
2013-03-25 04:55 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (40.18 KB, patch)
2013-03-25 05:29 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (45.92 KB, patch)
2013-03-25 07:17 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
Patch (43.61 KB, patch)
2013-03-28 06:37 PDT, Allan Sandfeld Jensen 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-03-25 04:44:06 PDT 
The software fallback for TextureMapper (Accelerated compositing), needs to apply filter effects in software like FilterEffectRenderer applies it on RenderLayer. To make this possible without calling renderer code from the graphics backend, FilterEffectRenderer should be split into a generic part for applying software filter effect, and a part that contains the Render-tree and DOM specific parts that shouldn't be used from the graphics backend.
Comment 1 Allan Sandfeld Jensen 2013-03-25 04:55:06 PDT 
Created attachment 194827 [details]
Patch
Comment 2 Early Warning System Bot 2013-03-25 05:02:12 PDT 
Comment on attachment 194827 [details]
Patch

Attachment 194827 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17232624
Comment 3 Early Warning System Bot 2013-03-25 05:03:13 PDT 
Comment on attachment 194827 [details]
Patch

Attachment 194827 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17291219
Comment 4 WebKit Review Bot 2013-03-25 05:16:47 PDT 
Comment on attachment 194827 [details]
Patch

Attachment 194827 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17241369
Comment 5 Allan Sandfeld Jensen 2013-03-25 05:29:48 PDT 
Created attachment 194833 [details]
Patch

Correct merge mistake
Comment 6 Build Bot 2013-03-25 06:07:43 PDT 
Comment on attachment 194833 [details]
Patch

Attachment 194833 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17324019
Comment 7 Build Bot 2013-03-25 06:09:48 PDT 
Comment on attachment 194833 [details]
Patch

Attachment 194833 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17294182
Comment 8 Noam Rosenthal 2013-03-25 07:17:32 PDT 
Created attachment 194848 [details]
Patch
Comment 9 Build Bot 2013-03-25 07:25:00 PDT 
Comment on attachment 194848 [details]
Patch

Attachment 194848 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17246414
Comment 10 Build Bot 2013-03-25 10:15:13 PDT 
Comment on attachment 194848 [details]
Patch

Attachment 194848 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17329042
Comment 11 Allan Sandfeld Jensen 2013-03-28 06:37:35 PDT 
Created attachment 195556 [details]
Patch
Comment 12 WebKit Review Bot 2013-03-28 06:45:20 PDT 
Comment on attachment 195556 [details]
Patch

Attachment 195556 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17257542
Comment 13 Build Bot 2013-03-28 06:51:30 PDT 
Comment on attachment 195556 [details]
Patch

Attachment 195556 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17330315
Comment 14 WebKit Review Bot 2013-03-28 06:56:15 PDT 
Comment on attachment 195556 [details]
Patch

Attachment 195556 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17330319
Comment 15 Peter Beverloo (cr-android ews) 2013-03-28 07:01:15 PDT 
Comment on attachment 195556 [details]
Patch

Attachment 195556 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17296438
Comment 16 Allan Sandfeld Jensen 2013-03-28 07:06:57 PDT 
Comment on attachment 195556 [details]
Patch

Needs rebase.
Comment 17 Build Bot 2013-03-29 11:41:52 PDT 
Comment on attachment 195556 [details]
Patch

Attachment 195556 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/17370027